[PATCH] packaged-staging: fixed fetching from PSTAGE_MIRROR with file:// uri

[PATCH] packaged-staging: fixed fetching from PSTAGE_MIRROR with file:// uri

[Aeschbacher, Fabrice]

Packaged-staging:

* This patch fixes fetching pre-built staging packages from PSTAGE_MIRROR having file:// uri
  (thanks to Tom Rini for helping me fixing this)

Signed-off-by: Fabrice Aeschbacher <fabrice.aeschbacher@siemens.com>
---
 classes/packaged-staging.bbclass |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/classes/packaged-staging.bbclass b/classes/packaged-staging.bbclass
index 29a3238..c60e271 100644
--- a/classes/packaged-staging.bbclass
+++ b/classes/packaged-staging.bbclass
@@ -200,10 +200,13 @@ def staging_fetch(stagepkg, d):
         try:
             bb.fetch.init([srcuri], pd)
             bb.fetch.go(pd, [srcuri])
+            stagepkg = bb.fetch.localpath(srcuri, pd)
         except Exception, ex:
-	    bb.debug(1, "Failed to fetch staging package %s: %s" % (bn, ex))
+            bb.debug(1, "Failed to fetch staging package %s: %s" % (bn, ex))
         else:
-	    bb.debug(1, "Fetched staging package %s" % bn)
+            bb.debug(1, "Fetched staging package %s" % bn)
+
+        return stagepkg
 
 PSTAGE_TASKS_COVERED = "fetch unpack munge patch configure qa_configure rig_locales compile sizecheck install deploy package populate_sysroot package_write_deb package_write_ipk package_write package_stage qa_staging"
 
@@ -222,7 +225,7 @@ python packagestage_scenefunc () {
 
     stagepkg = bb.data.expand("${PSTAGE_PKG}", d)
     if not os.path.exists(stagepkg):
-        staging_fetch(stagepkg, d)
+        stagepkg = staging_fetch(stagepkg, d)
 
     if os.path.exists(stagepkg):
         pstage_set_pkgmanager(d)
-- 
1.7.2.5

Re: [PATCH] packaged-staging: fixed fetching from PSTAGE_MIRROR with file:// uri

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 2335 bytes --]

Dear Fabrice,


thank you for your patch.

Am Sonntag, den 17.07.2011, 20:50 +0200 schrieb Aeschbacher, Fabrice:
> Packaged-staging:
> 
> * This patch fixes fetching pre-built staging packages from PSTAGE_MIRROR having file:// uri
>   (thanks to Tom Rini for helping me fixing this)

A link to the discussion in the archive would be great in my opinion.

http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-July/033938.html

Since your Signed-off-by line and From line differ slightly, you should
add

	From: Fabrice Aeschbacher <fabrice.aeschbacher@siemens.com>

to the beginning of your patches, i. e. first line of your message.

> Signed-off-by: Fabrice Aeschbacher <fabrice.aeschbacher@siemens.com>
> ---
>  classes/packaged-staging.bbclass |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/classes/packaged-staging.bbclass b/classes/packaged-staging.bbclass
> index 29a3238..c60e271 100644
> --- a/classes/packaged-staging.bbclass
> +++ b/classes/packaged-staging.bbclass
> @@ -200,10 +200,13 @@ def staging_fetch(stagepkg, d):
>          try:
>              bb.fetch.init([srcuri], pd)
>              bb.fetch.go(pd, [srcuri])
> +            stagepkg = bb.fetch.localpath(srcuri, pd)
>          except Exception, ex:
> -	    bb.debug(1, "Failed to fetch staging package %s: %s" % (bn, ex))
> +            bb.debug(1, "Failed to fetch staging package %s: %s" % (bn, ex))
>          else:
> -	    bb.debug(1, "Fetched staging package %s" % bn)
> +            bb.debug(1, "Fetched staging package %s" % bn)

White space changes always make reviews harder for me.

> +
> +        return stagepkg
>  
>  PSTAGE_TASKS_COVERED = "fetch unpack munge patch configure qa_configure rig_locales compile sizecheck install deploy package populate_sysroot package_write_deb package_write_ipk package_write package_stage qa_staging"
>  
> @@ -222,7 +225,7 @@ python packagestage_scenefunc () {
>  
>      stagepkg = bb.data.expand("${PSTAGE_PKG}", d)
>      if not os.path.exists(stagepkg):
> -        staging_fetch(stagepkg, d)
> +        stagepkg = staging_fetch(stagepkg, d)
>  
>      if os.path.exists(stagepkg):
>          pstage_set_pkgmanager(d)

Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v2] packaged-staging: fixed fetching from PSTAGE_MIRROR with file:// uri

[Aeschbacher, Fabrice]

From: Fabrice Aeschbacher <fabrice.aeschbacher@siemens.com>

Packaged-staging:
 
 * This patch fixes fetching pre-built staging packages from PSTAGE_MIRROR having file:// uri
   see: http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-July/033938.html
   (thanks to Tom Rini for helping me fixing this)

Signed-off-by: Fabrice Aeschbacher <fabrice.aeschbacher@siemens.com>
---
 classes/packaged-staging.bbclass |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/classes/packaged-staging.bbclass b/classes/packaged-staging.bbclass
index 29a3238..c60e271 100644
--- a/classes/packaged-staging.bbclass
+++ b/classes/packaged-staging.bbclass
@@ -200,11 +200,14 @@ def staging_fetch(stagepkg, d):
         try:
             bb.fetch.init([srcuri], pd)
             bb.fetch.go(pd, [srcuri])
+            stagepkg = bb.fetch.localpath(srcuri, pd)
         except Exception, ex:
 	    bb.debug(1, "Failed to fetch staging package %s: %s" % (bn, ex))
         else:
 	    bb.debug(1, "Fetched staging package %s" % bn)
 
+        return stagepkg
+
 PSTAGE_TASKS_COVERED = "fetch unpack munge patch configure qa_configure rig_locales compile sizecheck install deploy package populate_sysroot package_write_deb package_write_ipk package_write package_stage qa_staging"
 
 SCENEFUNCS += "packagestage_scenefunc"
@@ -222,7 +225,7 @@ python packagestage_scenefunc () {
 
     stagepkg = bb.data.expand("${PSTAGE_PKG}", d)
     if not os.path.exists(stagepkg):
-        staging_fetch(stagepkg, d)
+        stagepkg = staging_fetch(stagepkg, d)
 
     if os.path.exists(stagepkg):
         pstage_set_pkgmanager(d)
-- 
1.7.2.5

Re: [PATCH v2] packaged-staging: fixed fetching from PSTAGE_MIRROR with file:// uri

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Am Sonntag, den 17.07.2011, 21:42 +0200 schrieb Aeschbacher, Fabrice:
> From: Fabrice Aeschbacher <fabrice.aeschbacher@siemens.com>
> 
> Packaged-staging:
>  
>  * This patch fixes fetching pre-built staging packages from PSTAGE_MIRROR having file:// uri
>    see: http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-July/033938.html
>    (thanks to Tom Rini for helping me fixing this)
> 
> Signed-off-by: Fabrice Aeschbacher <fabrice.aeschbacher@siemens.com>

[…]

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

I would still waiting for Tom’s Acked-by or Signed-off-by line.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v2] packaged-staging: fixed fetching from PSTAGE_MIRROR with file:// uri

[Tom Rini]

On 07/17/2011 01:26 PM, Paul Menzel wrote:
> Am Sonntag, den 17.07.2011, 21:42 +0200 schrieb Aeschbacher, Fabrice:
>> From: Fabrice Aeschbacher <fabrice.aeschbacher@siemens.com>
>>
>> Packaged-staging:
>>  
>>  * This patch fixes fetching pre-built staging packages from PSTAGE_MIRROR having file:// uri
>>    see: http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-July/033938.html
>>    (thanks to Tom Rini for helping me fixing this)
>>
>> Signed-off-by: Fabrice Aeschbacher <fabrice.aeschbacher@siemens.com>
> 
> […]
> 
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
> 
> I would still waiting for Tom’s Acked-by or Signed-off-by line.

Acked-by: Tom Rini <tom_rini@mentor.com>

And for the records, I forget if we found that in poky at the time, I
came up with it or Chris Larson did.   But it's kosher any which way :)

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH v2] packaged-staging: fixed fetching from PSTAGE_MIRROR with file:// uri

[Aeschbacher, Fabrice]

Hi,

Would it be possible for someone having write access to commit this patch:

http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-July/033967.html

With kind regards,
Fabrice

> -----Ursprüngliche Nachricht-----
> Von: openembedded-devel-bounces@lists.openembedded.org 
> [mailto:openembedded-devel-bounces@lists.openembedded.org] Im 
> Auftrag von Tom Rini
> Gesendet: Montag, 18. Juli 2011 00:58
> An: openembedded-devel@lists.openembedded.org
> Betreff: Re: [oe] [PATCH v2] packaged-staging: fixed fetching 
> from PSTAGE_MIRROR with file:// uri
> 
> >> Signed-off-by: Fabrice Aeschbacher 
...
> > Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
...
> Acked-by: Tom Rini <tom_rini@mentor.com>

Re: [PATCH v2] packaged-staging: fixed fetching from PSTAGE_MIRROR with file:// uri

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

Dear Fabrice,


Am Donnerstag, den 28.07.2011, 10:44 +0200 schrieb Aeschbacher, Fabrice:

> Would it be possible for someone having write access to commit this patch:
> 
> http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-July/033967.html

[…]

I am sorry for the delay. I will push your patch as soon as possible.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]