From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] arm/km: fix u-boot.kwb build breakage
Date: Mon, 18 Jul 2011 11:41:28 +0200 [thread overview]
Message-ID: <4E23FFC8.8070009@keymile.com> (raw)
In-Reply-To: <4E216D43.4050107@aribaud.net>
Hi Albert,
On 07/16/2011 12:51 PM, Albert ARIBAUD wrote:
> Le 15/06/2011 09:38, Holger Brunck a ?crit :
>
>> I agree for a single board support, but this is not possible in our approach. We
>> include config_cmd_default.h in keymile-common.h. And keymile-common.h is valid
>> for our powerpc and arm boards. In km_arm.h we add the CMD settings which are
>> only additionaly needed on our arm boards.
>
> You can #undef things just as you can #define them after including default
> command headers -- I personally see no issue with this.
>
yes you are right it could be done this way. But I think it's more clearly
arranged if we only define the commands in keymile-common.h wich are common for
all keymile boards rather to define a superset there and undef them later on in
km-powerpc.h or km_arm.h.
Best regards
Holger Brunck
next prev parent reply other threads:[~2011-07-18 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 7:11 [U-Boot] [PATCH 1/2] arm/kirkwood: if CONFIG_SOFT_I2C is set don't set CONFIG_I2C_MVTWSI Holger Brunck
2011-06-14 7:11 ` [U-Boot] [PATCH 2/2] arm/km: fix u-boot.kwb build breakage Holger Brunck
2011-06-15 7:18 ` Prafulla Wadaskar
2011-06-15 7:38 ` Holger Brunck
2011-07-16 10:51 ` Albert ARIBAUD
2011-07-18 9:41 ` Holger Brunck [this message]
2011-06-15 7:21 ` [U-Boot] [PATCH 1/2] arm/kirkwood: if CONFIG_SOFT_I2C is set don't set CONFIG_I2C_MVTWSI Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E23FFC8.8070009@keymile.com \
--to=holger.brunck@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.