diff for duplicates of <4E242605.9050400@cam.ac.uk> diff --git a/a/1.txt b/N1/1.txt index 3ddfc75..abaf075 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -191,10 +191,10 @@ number of channels. >> + struct iio_dev_attr *this_attr = to_iio_dev_attr(attr); >> + >> + gain_real = simple_strtol(buf, NULL, 10); ->> + if (gain_real == 0) +>> + if (gain_real = 0) >> + return -EPERM; >> + for (i = 0; i < NUM_CHANNELS; i++) { ->> + if (gains[i] == gain_real) { +>> + if (gains[i] = gain_real) { >> + pdata->gain[this_attr->address] = i; >> + return count; >> + } @@ -296,7 +296,7 @@ variable name, or chip. Just general point. Don't bother with local variables for stuff that is only used once. Just makes reading harder. >> + ->> + if (diff == 1) { +>> + if (diff = 1) { >> + /*if in0_diff is true, reading in0_input still returns >> + * in0, but it is in0-in1, if you read in1_input >> + * then you get in1-in0 */ @@ -304,7 +304,7 @@ In a nutshell that explains why we don't use the interface you've gone with but have an explicit one for differential channels. (see the max1363 driver for examples). ->> + if ((pos_chan % 2) == 0) +>> + if ((pos_chan % 2) = 0) >> + neg_chan = pos_chan+1; >> + else >> + neg_chan = pos_chan-1; @@ -355,7 +355,7 @@ allows for either so we can keep this as is if you really want to. I'd like to see a little comment explaining what the calcuation is though! >> + ->> + if (status == 0) { +>> + if (status = 0) { >> + mutex_unlock(&pdata->lock); >> + if (sign) >> + return sprintf(buf, "%d.%.6d\n", whole, fract); @@ -517,7 +517,7 @@ give us a coherent general interface. >> + pdata->spi_dev = spi; >> + >> + pdata->indio_dev = iio_allocate_device(0); ->> + if (pdata->indio_dev == NULL) { +>> + if (pdata->indio_dev = NULL) { >> + ret = -ENOMEM; >> + goto error_free; >> + } @@ -596,4 +596,10 @@ where everyone expects to find it! > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -> +> + + +_______________________________________________ +lm-sensors mailing list +lm-sensors@lm-sensors.org +http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 1a8a2cb..abe2289 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\01310975165-19912-1-git-send-email-pthomas8589@gmail.com\0" "ref\04E241286.3090103@cam.ac.uk\0" "From\0Jonathan Cameron <jic23@cam.ac.uk>\0" - "Subject\0Re: [PATCH] iio: add support for Analog Devices ad7194 a/d converter\0" - "Date\0Mon, 18 Jul 2011 13:24:37 +0100\0" + "Subject\0Re: [lm-sensors] [PATCH] iio: add support for Analog Devices ad7194\0" + "Date\0Mon, 18 Jul 2011 12:24:37 +0000\0" "To\0Jonathan Cameron <jic23@cam.ac.uk>\0" "Cc\0Paul Thomas <pthomas8589@gmail.com>" lm-sensors@lm-sensors.org @@ -203,10 +203,10 @@ ">> +\tstruct iio_dev_attr *this_attr = to_iio_dev_attr(attr);\n" ">> +\n" ">> +\tgain_real = simple_strtol(buf, NULL, 10);\n" - ">> +\tif (gain_real == 0)\n" + ">> +\tif (gain_real = 0)\n" ">> +\t\treturn -EPERM;\n" ">> +\tfor (i = 0; i < NUM_CHANNELS; i++) {\n" - ">> +\t\tif (gains[i] == gain_real) {\n" + ">> +\t\tif (gains[i] = gain_real) {\n" ">> +\t\t\tpdata->gain[this_attr->address] = i;\n" ">> +\t\t\treturn count;\n" ">> +\t\t}\n" @@ -308,7 +308,7 @@ "Just general point. Don't bother with local variables for stuff that\n" "is only used once. Just makes reading harder.\n" ">> +\n" - ">> +\tif (diff == 1) {\n" + ">> +\tif (diff = 1) {\n" ">> +\t\t/*if in0_diff is true, reading in0_input still returns\n" ">> +\t\t* in0, but it is in0-in1, if you read in1_input\n" ">> +\t\t* then you get in1-in0 */\n" @@ -316,7 +316,7 @@ "with but have an explicit one for differential channels. (see the max1363\n" "driver for examples).\n" "\n" - ">> +\t\tif ((pos_chan % 2) == 0)\n" + ">> +\t\tif ((pos_chan % 2) = 0)\n" ">> +\t\t\tneg_chan = pos_chan+1;\n" ">> +\t\telse\n" ">> +\t\t\tneg_chan = pos_chan-1;\n" @@ -367,7 +367,7 @@ "I'd like to see a little comment explaining what the calcuation is\n" "though!\n" ">> +\n" - ">> +\tif (status == 0) {\n" + ">> +\tif (status = 0) {\n" ">> +\t\tmutex_unlock(&pdata->lock);\n" ">> +\t\tif (sign)\n" ">> +\t\t\treturn sprintf(buf, \"%d.%.6d\\n\", whole, fract);\n" @@ -529,7 +529,7 @@ ">> +\tpdata->spi_dev = spi;\n" ">> +\n" ">> +\tpdata->indio_dev = iio_allocate_device(0);\n" - ">> +\tif (pdata->indio_dev == NULL) {\n" + ">> +\tif (pdata->indio_dev = NULL) {\n" ">> +\t\tret = -ENOMEM;\n" ">> +\t\tgoto error_free;\n" ">> +\t}\n" @@ -608,6 +608,12 @@ "> To unsubscribe from this list: send the line \"unsubscribe linux-iio\" in\n" "> the body of a message to majordomo@vger.kernel.org\n" "> More majordomo info at http://vger.kernel.org/majordomo-info.html\n" - > + "> \n" + "\n" + "\n" + "_______________________________________________\n" + "lm-sensors mailing list\n" + "lm-sensors@lm-sensors.org\n" + http://lists.lm-sensors.org/mailman/listinfo/lm-sensors -025812eb01097268c77f44e1bec09b96ffdb02bd5a6f93c1cb69d0ee4f7d17c6 +f6491eba3fe9c4ebd6f5c0041a049e34dcfb59bc8566a8e8878e62074a970314
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.