All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"patches@opensource.wolfsonmicro.com"
	<patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: Mark cache as dirty when suspending
Date: Mon, 18 Jul 2011 13:39:04 +0100	[thread overview]
Message-ID: <4E242968.8040603@ti.com> (raw)
In-Reply-To: <1310963139-32251-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On 18/07/11 05:25, Mark Brown wrote:
> Since quite a few drivers are not managing to flag the cache as needing
> to be resynced after suspend and it's a reasonable thing to do flag the
> cache as needing sync automatically when suspending.
> 
> The expectation is that systems will mainly only keep the CODEC powered
> when doing audio through the CODEC so we won't actually suspend the
> device anyway; drivers which want to can override this behaviour when
> they resume.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  sound/soc/soc-core.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index e44267f..93109a4 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -577,6 +577,7 @@ int snd_soc_suspend(struct device *dev)
>  			case SND_SOC_BIAS_OFF:
>  				codec->driver->suspend(codec, PMSG_SUSPEND);
>  				codec->suspended = 1;
> +				codec->cache_sync = 1;
>  				break;
>  			default:
>  				dev_dbg(codec->dev, "CODEC is on over suspend\n");

Acked-by: Liam Girdwood <lrg@ti.com>

      reply	other threads:[~2011-07-18 12:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-18  4:25 [PATCH] ASoC: Mark cache as dirty when suspending Mark Brown
2011-07-18 12:39 ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E242968.8040603@ti.com \
    --to=lrg@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.