From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57975)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QiotW-0003rX-Tc
	for qemu-devel@nongnu.org; Mon, 18 Jul 2011 10:34:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QiotR-0007wX-TF
	for qemu-devel@nongnu.org; Mon, 18 Jul 2011 10:34:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23492)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QiotR-0007wA-GE
	for qemu-devel@nongnu.org; Mon, 18 Jul 2011 10:33:57 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6IEXt4L013177
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 18 Jul 2011 10:33:55 -0400
Message-ID: <4E244447.7090807@redhat.com>
Date: Mon, 18 Jul 2011 16:33:43 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1310973217-12242-1-git-send-email-hdegoede@redhat.com>
In-Reply-To: <1310973217-12242-1-git-send-email-hdegoede@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] USB: add usb network redirection support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org

On 07/18/11 09:13, Hans de Goede wrote:
> This patch adds support for a usb-redir device, which takes a chardev
> as a communication channel to an actual usbdevice using the usbredir protocol.
>
> Compiling the usb-redir device requires usbredir-0.3 to be installed for
> the usbredir protocol parser, usbredir-0.3 also contains a server for
> redirecting usb traffic from an actual usb device. You can get the 0.3
> release of usbredir here:
> http://people.fedoraproject.org/~jwrdegoede/usbredir-0.3.tar.bz2
> (getting a more formal site for it is a WIP)

Looks good overall.  scripts/checkpatch.pl has a bunch of codestyle 
complains which need to be fixed.

cheers,
   Gerd