All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Mallon <rmallon@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Ravishankar <ravishankarkm32@gmail.com>,
	devel@driverdev.osuosl.org, gregkh@suse.de,
	linux-kernel@vger.kernel.org,
	Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH 1/2 v3] Staging: comedi: fix printk() issue in adv_pci1710.c
Date: Tue, 19 Jul 2011 16:15:51 +1000	[thread overview]
Message-ID: <4E252117.4000500@gmail.com> (raw)
In-Reply-To: <20110719061226.GF4010@shale.localdomain>

On 19/07/11 16:12, Dan Carpenter wrote:
> On Tue, Jul 19, 2011 at 04:07:27PM +1000, Ryan Mallon wrote:
>> This still isn't correct. The initial printk (KERN_INFO above) has
>> no trailing newline. Here you are almost doing it correctly, except
>> that you are adding an extra newline. This error message will look
>> like this:
>>
>> comedi0: adv_pci1710:
>> comedi0: adv_pci1710: Allocation failed
>>
> Actually kmalloc() prints an message with a stack trace on failure as
> well so that would go in the middle, just before the first newline.
>

Thanks. Didn't know that. Is that a KConfig option or by default?

Either way, it's another good reason to get rid of all the KERN_CONT 
stuff in the driver.

~Ryan

  reply	other threads:[~2011-07-19  6:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <[PATCH]Staging: comedi: fix printk() issue in adv_pci1710.c>
2011-07-19  3:52 ` [PATCH 1/2 v2] Staging: comedi: fix printk() issue in adv_pci1710.c Ravishankar
2011-07-19  3:55   ` Joe Perches
2011-07-19  4:55 ` [PATCH 1/2 v3] " Ravishankar
2011-07-19  4:52   ` Joe Perches
2011-07-19  5:50 ` Ravishankar
2011-07-19  6:07   ` Ryan Mallon
2011-07-19  6:12     ` Dan Carpenter
2011-07-19  6:15       ` Ryan Mallon [this message]
2011-07-19  6:25         ` Dan Carpenter
2011-07-19 23:44     ` Ryan Mallon
     [not found] <[PATCH]Staging: Comedi: fix printk issue in adv_pci1710.c>
2011-07-22 11:24 ` [PATCH 1/2 v3] Staging: comedi: fix printk " Ravishankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E252117.4000500@gmail.com \
    --to=rmallon@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=error27@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ravi.shankar@greenturtles.in \
    --cc=ravishankarkm32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.