From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] Armada100: Enable 88E3015 PHY support for GplugD
Date: Tue, 19 Jul 2011 10:23:21 +0200 [thread overview]
Message-ID: <4E253EF9.7040907@aribaud.net> (raw)
In-Reply-To: <689858104.27342.1311048656182.JavaMail.root@ahm.einfochips.com>
Hi Ajay,
Le 19/07/2011 06:10, Ajay Bhargav a ?crit :
>>> + gpio_set_value(CONFIG_SYS_GPIO_PHY_RST, GPIO_SET);
>>
>> May you please comment why do you need to set this GPIO?
>
> GPIO 104 is connected to reset pin of 88E3015 PHY. and a reset is
> required before initializing PHY chip.
I believe Prafulla would like this comment to appear in the code --
anyway, *I* would like it to. :)
> Regards,
> Ajay Bhargav
Amicalement,
--
Albert.
next prev parent reply other threads:[~2011-07-19 8:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 9:41 [U-Boot] [PATCH 3/4] Armada100: Enable 88E3015 PHY support for GplugD Ajay Bhargav
2011-07-18 19:27 ` Prafulla Wadaskar
2011-07-19 4:10 ` Ajay Bhargav
2011-07-19 8:23 ` Albert ARIBAUD [this message]
2011-07-19 8:16 ` Ajay Bhargav
2011-07-19 17:52 ` Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E253EF9.7040907@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.