From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: David Miller <davem@davemloft.net>,
rweikusat@mobileactivedefense.com,
netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter: add per-namespace logging to nfnetlink_log.c
Date: Tue, 19 Jul 2011 11:42:26 +0200 [thread overview]
Message-ID: <4E255182.8090009@trash.net> (raw)
In-Reply-To: <20110718203249.GC2489@p183.telecom.by>
On 18.07.2011 22:32, Alexey Dobriyan wrote:
> On Mon, Jul 18, 2011 at 01:19:43PM -0700, David Miller wrote:
>> From: Rainer Weikusat <rweikusat@mobileactivedefense.com>
>> Date: Mon, 18 Jul 2011 21:17:00 +0100
>>
>>> David Miller <davem@davemloft.net> writes:
>>>> We're also specifically talking about namespace stuff, so you should have
>>>> at least refined your match criteria just a little bit.
>>>
>>> The person I was replying to wrote 'We did whole networking without
>>> sprinkling ifdefs'.
>>
>> He was talking specifically about namespace stuff.
>
> Indeed.
>
> Rainer, while your desire to keep CONFIG_NET_NS=n case equivalent
> to current code is understandable and kernel people share it at large,
> what you're fighting for is maybe one dereference on speed-uncritical
> code paths and one pointer in small amount of data structures.
> As such having common executable code matters more.
>
> netns will be stubbed to &init_net at several places.
> See how e. g. xt_hashlimit is done.
Indeed, that's the alternative to putting it directly into struct
netns, not using tons of ifdefs.
next prev parent reply other threads:[~2011-07-19 9:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 14:44 [PATCH] netfilter: add per-namespace logging to nfnetlink_log.c Rainer Weikusat
2011-07-18 16:21 ` Patrick McHardy
2011-07-18 17:56 ` Rainer Weikusat
2011-07-18 19:11 ` Rainer Weikusat
2011-07-18 19:19 ` Alexey Dobriyan
2011-07-18 19:43 ` Rainer Weikusat
2011-07-18 19:46 ` David Miller
2011-07-18 20:17 ` Rainer Weikusat
2011-07-18 20:19 ` David Miller
2011-07-18 20:32 ` Alexey Dobriyan
2011-07-19 9:42 ` Patrick McHardy [this message]
2011-07-18 20:27 ` Eric Dumazet
2011-07-18 20:27 ` Eric Dumazet
2011-07-18 20:28 ` Jan Engelhardt
2011-07-19 21:38 ` Rainer Weikusat
2011-07-20 15:04 ` [PATCH] netfilter: add per-namespace logging to nfnetlink_log.c (updated) Rainer Weikusat
2011-07-26 11:22 ` Rainer Weikusat
2011-07-26 11:37 ` [PATCH] netfilter: add per-namespace logging to nfnetlink_log.c (updated again) Rainer Weikusat
2011-07-28 7:00 ` Patrick McHardy
2011-07-28 19:56 ` Rainer Weikusat
2011-07-28 19:57 ` [PATCH] netfilter: add per-namespace logging to nfnetlink_log.c (updated yet again) Rainer Weikusat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E255182.8090009@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rweikusat@mobileactivedefense.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.