From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [RFC v4 00/58] Memory API Date: Tue, 19 Jul 2011 19:01:16 +0200 Message-ID: <4E25B85C.1030809@siemens.com> References: <1310901265-32051-1-git-send-email-avi@redhat.com> <20110719135601.GA7194@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , qemu-devel@nongnu.org, kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from thoth.sbs.de ([192.35.17.2]:21053 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001Ab1GSRB2 (ORCPT ); Tue, 19 Jul 2011 13:01:28 -0400 In-Reply-To: <20110719135601.GA7194@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-07-19 15:56, Michael S. Tsirkin wrote: > On Sun, Jul 17, 2011 at 02:13:27PM +0300, Avi Kivity wrote: >> New in this version: >> MemoryRegionOps gained .old_mmio and .old_portio members, which allow >> reusing old-style callbacks with the new API. All uses were converted, >> except for eepro100.c, which uses the same MemoryRegionOps for both >> portio and mmio. Some intermediate patches do introduce dispatching >> callbacks, but they are removed later. >> >> Caveats: >> - some devices still grab a global memory region instead of inheriting >> it from their bus. Seen in the code as #include "exec-memory.h" > > Looks good to me. > > It looks like with this, users of vga_dirty_log_stop > like qxl_write_config can go away because the region can > stay registered with dirty logging enabled? That was already possible with the old API, see [1]. Makes me wonder what will be merged first... Jan [1] http://thread.gmane.org/gmane.comp.emulators.qemu/106150 -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjDfl-0002lE-UQ for qemu-devel@nongnu.org; Tue, 19 Jul 2011 13:01:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjDff-0005B0-Ht for qemu-devel@nongnu.org; Tue, 19 Jul 2011 13:01:29 -0400 Received: from thoth.sbs.de ([192.35.17.2]:28882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjDfe-0005AC-Pb for qemu-devel@nongnu.org; Tue, 19 Jul 2011 13:01:23 -0400 Message-ID: <4E25B85C.1030809@siemens.com> Date: Tue, 19 Jul 2011 19:01:16 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1310901265-32051-1-git-send-email-avi@redhat.com> <20110719135601.GA7194@redhat.com> In-Reply-To: <20110719135601.GA7194@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v4 00/58] Memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Avi Kivity , kvm@vger.kernel.org, qemu-devel@nongnu.org On 2011-07-19 15:56, Michael S. Tsirkin wrote: > On Sun, Jul 17, 2011 at 02:13:27PM +0300, Avi Kivity wrote: >> New in this version: >> MemoryRegionOps gained .old_mmio and .old_portio members, which allow >> reusing old-style callbacks with the new API. All uses were converted, >> except for eepro100.c, which uses the same MemoryRegionOps for both >> portio and mmio. Some intermediate patches do introduce dispatching >> callbacks, but they are removed later. >> >> Caveats: >> - some devices still grab a global memory region instead of inheriting >> it from their bus. Seen in the code as #include "exec-memory.h" > > Looks good to me. > > It looks like with this, users of vga_dirty_log_stop > like qxl_write_config can go away because the region can > stay registered with dirty logging enabled? That was already possible with the old API, see [1]. Makes me wonder what will be merged first... Jan [1] http://thread.gmane.org/gmane.comp.emulators.qemu/106150 -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux