From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjGIN-0005Ln-KD for qemu-devel@nongnu.org; Tue, 19 Jul 2011 15:49:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjGIL-0006b9-E9 for qemu-devel@nongnu.org; Tue, 19 Jul 2011 15:49:31 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:60872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjGIK-0006aw-Uo for qemu-devel@nongnu.org; Tue, 19 Jul 2011 15:49:29 -0400 Message-ID: <4E25DFC2.6030900@msgid.tls.msk.ru> Date: Tue, 19 Jul 2011 23:49:22 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1311103418-29380-1-git-send-email-rjones@redhat.com> <1311103418-29380-2-git-send-email-rjones@redhat.com> In-Reply-To: <1311103418-29380-2-git-send-email-rjones@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Remove debugging messages. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org 19.07.2011 23:23, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" > > When using qemu -machine accel=kvm:tcg, if KVM is not available you > get a load of debugging output: > > Could not access KVM kernel module: No such file or directory > failed to initialize KVM: No such file or directory > Back to tcg accelerator. > > Signed-off-by: Richard W.M. Jones > --- > kvm-all.c | 1 - > vl.c | 14 -------------- > 2 files changed, 0 insertions(+), 15 deletions(-) > > diff --git a/kvm-all.c b/kvm-all.c > index cbc2532..35d698b 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -713,7 +713,6 @@ int kvm_init(void) > s->vmfd = -1; > s->fd = qemu_open("/dev/kvm", O_RDWR); > if (s->fd == -1) { > - fprintf(stderr, "Could not access KVM kernel module: %m\n"); Don't do this. qemu error reporting sucks badly already, and this very error message gives us at least some details (the %m part) about what's missing. There's no other place where this information is printed in case this open fails. We already have to resort to strace in way too many places... :( Thanks, /mjt