From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 14/16] clutter-box2d: Replace use of finite macro with C99 compliant isfinite()
Date: Tue, 19 Jul 2011 17:45:49 -0700 [thread overview]
Message-ID: <4E26253D.8040000@linux.intel.com> (raw)
In-Reply-To: <d12eac7e3b3d9c368f99e4163fb297858e577d00.1311034342.git.raj.khem@gmail.com>
On 07/18/2011 05:17 PM, Khem Raj wrote:
> Signed-off-by: Khem Raj<raj.khem@gmail.com>
> ---
> .../clutter/clutter-box2d/isfinite.patch | 19 +++++++++++++++++++
> meta/recipes-graphics/clutter/clutter-box2d_git.bb | 6 ++++--
> 2 files changed, 23 insertions(+), 2 deletions(-)
> create mode 100644 meta/recipes-graphics/clutter/clutter-box2d/isfinite.patch
>
> diff --git a/meta/recipes-graphics/clutter/clutter-box2d/isfinite.patch b/meta/recipes-graphics/clutter/clutter-box2d/isfinite.patch
> new file mode 100644
> index 0000000..fd2bf74
> --- /dev/null
> +++ b/meta/recipes-graphics/clutter/clutter-box2d/isfinite.patch
> @@ -0,0 +1,19 @@
> +_finite is obsoleted and C99 has isfinite instead so we should use it
> +
> +Signed-off-by: Khem Raj<raj.khem@gmail.com>
> +
> +Upstream-Status: Pending
> +
> +Index: clutter-box2d-0.10.0/box2d/Source/Common/b2Math.h
> +===================================================================
> +--- clutter-box2d-0.10.0.orig/box2d/Source/Common/b2Math.h 2008-12-16 06:42:10.000000000 -0800
> ++++ clutter-box2d-0.10.0/box2d/Source/Common/b2Math.h 2011-07-17 02:10:29.833825198 -0700
> +@@ -60,7 +60,7 @@
> + #ifdef _MSC_VER
> + return _finite(x) != 0;
> + #else
> +- return finite(x) != 0;
> ++ return std::isfinite(x) != 0;
> + #endif
> + }
> +
> diff --git a/meta/recipes-graphics/clutter/clutter-box2d_git.bb b/meta/recipes-graphics/clutter/clutter-box2d_git.bb
> index bfd46b2..06f5fa2 100644
> --- a/meta/recipes-graphics/clutter/clutter-box2d_git.bb
> +++ b/meta/recipes-graphics/clutter/clutter-box2d_git.bb
> @@ -4,9 +4,11 @@ LIC_FILES_CHKSUM = "file://box2d/License.txt;md5=e5d39ad91f7dc4692dcdb1d85139ec6
>
> SRCREV = "4799ac10ae8cb7da936a2b999aba58fe62eb1ee3"
> PV = "0.10.1+git${SRCPV}"
> -PR = "r0"
> +PR = "r1"
>
> -SRC_URI = "git://git.gnome.org/clutter-box2d.git"
> +SRC_URI = "git://git.gnome.org/clutter-box2d.git \
> + file://isfinite.patch \
> + "
>
> S = "${WORKDIR}/git"
>
Khem,
This patch seems to have patched clutter-box2d-1.6_0.10.0.bb also, with
the isfinite patch. This fails to apply. Was this intentional were you
planning on updating the 1.6 version?
Sau!
next prev parent reply other threads:[~2011-07-20 0:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 0:17 [PATCH 00/16] Make core-image-minimal core-image-sato buildable with uclibc Khem Raj
2011-07-19 0:17 ` [PATCH 01/16] bitbake.conf: Change TERM default fallback to XTERM instead of GNOME_TERM Khem Raj
2011-07-19 0:17 ` [PATCH 02/16] oe-buildenv-internal: Replace POKYMODE POKYLIBC with TCMODE and TCLIBC Khem Raj
2011-07-19 0:17 ` [PATCH 03/16] default-distrovars: Add largefile and argp to DISTRO_FEATURES Khem Raj
2011-07-19 0:17 ` [PATCH 04/16] acl, attr: Fix build failures when NLS is disabled on uclibc Khem Raj
2011-07-19 0:17 ` [PATCH 05/16] classes/gettext: Do not disable nls for non target recipes Khem Raj
2011-07-19 0:17 ` [PATCH 06/16] libxdamage, libxft, libxrandr: Add missing dependency on virtual/libx11 Khem Raj
2011-07-19 0:17 ` [PATCH 07/16] tzcode,tzdata: Update tzdata to 2011h Khem Raj
2011-07-19 0:17 ` [PATCH 08/16] task-core-x11-sato: Add empty NETWORK_MANAGER for uclibc Khem Raj
2011-07-19 0:17 ` [PATCH 09/16] uclibc_0.9.32: Implement sync_file_range2 Khem Raj
2011-07-19 11:07 ` Phil Blundell
2011-07-19 14:45 ` Khem Raj
2011-07-19 21:14 ` Khem Raj
2011-07-19 0:17 ` [PATCH 10/16] oprofile: Fix build when query_module is not there Khem Raj
2011-07-19 0:17 ` [PATCH 11/16] powertop: Add lintl to linker commandline on uclibc Khem Raj
2011-07-19 0:17 ` [PATCH 12/16] pimlico/dates: Fix build " Khem Raj
2011-07-19 0:17 ` [PATCH 13/16] binutils: Fix build when compiling target binutils recipe with gcc 4.6 Khem Raj
2011-07-19 0:17 ` [PATCH 14/16] clutter-box2d: Replace use of finite macro with C99 compliant isfinite() Khem Raj
2011-07-20 0:45 ` Saul Wold [this message]
2011-07-20 4:33 ` Khem Raj
2011-07-20 5:15 ` Khem Raj
2011-07-19 0:17 ` [PATCH 15/16] sysprof: Define NT_GNU_BUILD_ID if undefined Khem Raj
2011-07-19 0:17 ` [PATCH 16/16] mesa-xlib: Dont use locales with uclibc Khem Raj
2011-07-19 21:16 ` [PATCH 00/16] Make core-image-minimal core-image-sato buildable " Khem Raj
2011-07-20 17:28 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E26253D.8040000@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.