From: Greg Dietsche <gregory.dietsche@cuw.edu>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] frv: remove unnecessary code
Date: Wed, 20 Jul 2011 02:03:57 +0000 [thread overview]
Message-ID: <4E26378D.9090500@cuw.edu> (raw)
In-Reply-To: <1308242660-29054-1-git-send-email-Gregory.Dietsche@cuw.edu>
On 07/09/2011 10:29 AM, Greg Dietsche wrote:
> On Thu, Jun 16, 2011 at 11:44:20AM -0500, Greg Dietsche wrote:
>
>> remove unnecessary code that matches this coccinelle pattern
>> if (...)
>> return ret;
>> return ret;
>>
>> Signed-off-by: Greg Dietsche<Gregory.Dietsche@cuw.edu>
>> ---
>> arch/frv/mm/pgalloc.c | 8 +-------
>> 1 files changed, 1 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/frv/mm/pgalloc.c b/arch/frv/mm/pgalloc.c
>> index c42c83d..4fb63a3 100644
>> --- a/arch/frv/mm/pgalloc.c
>> +++ b/arch/frv/mm/pgalloc.c
>> @@ -133,13 +133,7 @@ void pgd_dtor(void *pgd)
>>
>> pgd_t *pgd_alloc(struct mm_struct *mm)
>> {
>> - pgd_t *pgd;
>> -
>> - pgd = quicklist_alloc(0, GFP_KERNEL, pgd_ctor);
>> - if (!pgd)
>> - return pgd;
>> -
>> - return pgd;
>> + return quicklist_alloc(0, GFP_KERNEL, pgd_ctor);
>> }
>>
>> void pgd_free(struct mm_struct *mm, pgd_t *pgd)
>> --
>> 1.7.2.5
>>
>> --
>>
> Any feedback on this patch?
>
> Thanks!
> Greg
>
>
adding trivial@kernel.org to the cc list since this is trivial and no
one has picked up this patch to date.
Greg
next prev parent reply other threads:[~2011-07-20 2:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 16:44 [PATCH] frv: remove unnecessary code Greg Dietsche
2011-07-09 15:29 ` Greg Dietsche
2011-07-20 2:03 ` Greg Dietsche [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-29 15:46 David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E26378D.9090500@cuw.edu \
--to=gregory.dietsche@cuw.edu \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.