From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjVgL-00051i-Uu for qemu-devel@nongnu.org; Wed, 20 Jul 2011 08:15:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjVgF-0004zq-56 for qemu-devel@nongnu.org; Wed, 20 Jul 2011 08:15:17 -0400 Received: from goliath.siemens.de ([192.35.17.28]:34476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjVgE-0004wD-Md for qemu-devel@nongnu.org; Wed, 20 Jul 2011 08:15:11 -0400 Message-ID: <4E26C6C5.3060505@siemens.com> Date: Wed, 20 Jul 2011 14:15:01 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E25F976.8010200@web.de> <20110720120027.GI3699@valinux.co.jp> In-Reply-To: <20110720120027.GI3699@valinux.co.jp> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pci: Length-align config space accesses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: Avi Kivity , qemu-devel , "Michael S. Tsirkin" On 2011-07-20 14:00, Isaku Yamahata wrote: > Hi. This clean up looks good basically. Oops, forgot to cc you. Sorry. > But when conventional pci device is accessed via MMCONFIG area, > addr &= addr_mask doesn't work as expected. > The config area of [256, 4K) of conventional pci should have no effect. Mmh, I see. Looks like we need to split accesses at this boundary and executed them separately. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux