From: Jan Kiszka <jan.kiszka@siemens.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pci: Length-align config space accesses
Date: Wed, 20 Jul 2011 16:27:08 +0200 [thread overview]
Message-ID: <4E26E5BC.6040508@siemens.com> (raw)
In-Reply-To: <4E26C6C5.3060505@siemens.com>
On 2011-07-20 14:15, Jan Kiszka wrote:
> On 2011-07-20 14:00, Isaku Yamahata wrote:
>> Hi. This clean up looks good basically.
>
> Oops, forgot to cc you. Sorry.
>
>> But when conventional pci device is accessed via MMCONFIG area,
>> addr &= addr_mask doesn't work as expected.
>> The config area of [256, 4K) of conventional pci should have no effect.
>
> Mmh, I see. Looks like we need to split accesses at this boundary and
> executed them separately.
Nope, no such issue: we already automatically split up accesses that
span the legacy/extended boundary. Just like so far, legacy config space
handlers have to filter out requests that address regions >= 256.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-07-20 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 21:39 [Qemu-devel] [PATCH] pci: Length-align config space accesses Jan Kiszka
2011-07-20 12:00 ` Isaku Yamahata
2011-07-20 12:15 ` Jan Kiszka
2011-07-20 14:27 ` Jan Kiszka [this message]
2011-07-20 16:17 ` Isaku Yamahata
2011-07-20 16:18 ` Jan Kiszka
2011-07-20 16:33 ` Isaku Yamahata
2011-07-20 16:45 ` Michael S. Tsirkin
2011-07-20 17:10 ` Jan Kiszka
2011-07-20 20:16 ` Michael S. Tsirkin
2011-07-20 16:19 ` Michael S. Tsirkin
2011-07-20 14:22 ` Michael S. Tsirkin
2011-07-20 14:36 ` Jan Kiszka
2011-07-20 15:47 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E26E5BC.6040508@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.