All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Barada <peter.barada@gmail.com>
To: Ivan Djelic <ivan.djelic@parrot.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Peter Barada <peter.barada@logicpd.com>,
	"dedekind1@gmail.com" <dedekind1@gmail.com>
Subject: Re: Preventing JFFS2 partial page writes?
Date: Wed, 20 Jul 2011 11:02:59 -0400	[thread overview]
Message-ID: <4E26EE23.4030805@gmail.com> (raw)
In-Reply-To: <20110701205205.GA4600@parrot.com>

On 07/01/2011 04:52 PM, Ivan Djelic wrote:
> On Thu, Jun 30, 2011 at 07:05:25PM +0100, Peter Barada wrote:
> (...)
>>>> Another issue this exposes is that JFFS2 reads/compares the cleanmarker
>>>> w/o any ECC in the marker data to verify its validity - if a bitflip in
>>>> an unECC'd cleanmarker is read back, then I think JFFS2 will fail to use
>>>> that block.
>>> No, I think what JFFS2 should do is just assume the eraseblock needs
>>> erasure and just erase it. The whole purpose of clean markers is to
>>> erase less. If it is corrupted - we just do an extra erase - not big
>>> deal.
>> How's the best way to do this?  That would make this whole problem just
>> go away, and make MLC devices much more happy with JFFS2.
> I think Artem was just explaining that a single corrupted cleanmarker is no
> big deal, it just forces JFFS2 to perform an extra erase. That does not mean
> you can get rid of cleanmarkers, because systematically erasing a block before
> programming it would seriously degrade write performance.
What I meant was that for the first write to a block (which I hope will 
be to the page that contains the cleanmarker), erase the block before 
the write, merge the page data and clean marker into one write).  This 
shouldn't degrade performance that much (and could be enabled/disabled 
by a mount option).  If that is possible (and someone can provide a 
pointer to me on how to do such) its a much better solution than 
butchering ecclayout.

> --
> Best Regards,
>
> Ivan


-- 
Peter Barada
peter.barada@gmail.com

      reply	other threads:[~2011-07-20 15:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 16:19 Preventing JFFS2 partial page writes? Peter Barada
2011-06-22  6:04 ` Artem Bityutskiy
2011-06-22 15:28   ` Peter Barada
2011-06-22 17:07     ` Ivan Djelic
2011-06-22 19:17       ` Peter Barada
2011-06-22 20:06         ` Ivan Djelic
2011-06-24 15:09           ` Peter Barada
2011-06-24 19:26     ` Artem Bityutskiy
2011-06-27 14:31       ` Peter Barada
2011-06-28  9:34         ` Artem Bityutskiy
2011-06-28  9:39           ` Artem Bityutskiy
2011-07-01 20:48             ` Ivan Djelic
2011-07-04  6:27               ` Artem Bityutskiy
2011-06-28 18:56           ` Peter Barada
2011-06-29  6:33             ` Artem Bityutskiy
2011-06-30 18:05               ` Peter Barada
2011-07-01 20:52                 ` Ivan Djelic
2011-07-20 15:02                   ` Peter Barada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E26EE23.4030805@gmail.com \
    --to=peter.barada@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=ivan.djelic@parrot.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=peter.barada@logicpd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.