From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [RFC v5 00/86] Memory API Date: Wed, 20 Jul 2011 19:41:02 +0200 Message-ID: <4E27132E.6080504@siemens.com> References: <1311180636-17012-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from david.siemens.de ([192.35.17.14]:27937 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302Ab1GTRlK (ORCPT ); Wed, 20 Jul 2011 13:41:10 -0400 In-Reply-To: <1311180636-17012-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-07-20 18:49, Avi Kivity wrote: > New in this version: > - more mindless conversions; I believe there are no longer any destructive > operations in the tree (IO_MEM_UNASSIGNED) > - fix memory map generation bug (patch 13) > - proper 440FX PAM/SMRAM and PCI holes > This on top fixes standard VGA dirty logging: diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index e367052..8e8b24c 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -2944,8 +2944,6 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev) memory_region_add_subregion(&s->pci_bar, 0x1000000, &s->cirrus_linear_bitblt_io); - vga_dirty_log_start(&s->vga); - /* setup memory space */ /* memory #0 LFB */ /* memory #1 memory-mapped I/O */ diff --git a/hw/vga.c b/hw/vga.c index 5a78b71..8acc545 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -2195,6 +2195,7 @@ void vga_common_init(VGACommonState *s, int vga_ram_size) s->update_retrace_info = vga_precise_update_retrace_info; break; } + vga_dirty_log_start(s); } /* used by both ISA and PCI */ Cirrus is still broken (test case: grub), debugging ATM. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qjali-0002AZ-Aw for qemu-devel@nongnu.org; Wed, 20 Jul 2011 13:41:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qjalf-0008AS-Im for qemu-devel@nongnu.org; Wed, 20 Jul 2011 13:41:09 -0400 Received: from david.siemens.de ([192.35.17.14]:31219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qjale-00089y-RX for qemu-devel@nongnu.org; Wed, 20 Jul 2011 13:41:07 -0400 Message-ID: <4E27132E.6080504@siemens.com> Date: Wed, 20 Jul 2011 19:41:02 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1311180636-17012-1-git-send-email-avi@redhat.com> In-Reply-To: <1311180636-17012-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v5 00/86] Memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 2011-07-20 18:49, Avi Kivity wrote: > New in this version: > - more mindless conversions; I believe there are no longer any destructive > operations in the tree (IO_MEM_UNASSIGNED) > - fix memory map generation bug (patch 13) > - proper 440FX PAM/SMRAM and PCI holes > This on top fixes standard VGA dirty logging: diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index e367052..8e8b24c 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -2944,8 +2944,6 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev) memory_region_add_subregion(&s->pci_bar, 0x1000000, &s->cirrus_linear_bitblt_io); - vga_dirty_log_start(&s->vga); - /* setup memory space */ /* memory #0 LFB */ /* memory #1 memory-mapped I/O */ diff --git a/hw/vga.c b/hw/vga.c index 5a78b71..8acc545 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -2195,6 +2195,7 @@ void vga_common_init(VGACommonState *s, int vga_ram_size) s->update_retrace_info = vga_precise_update_retrace_info; break; } + vga_dirty_log_start(s); } /* used by both ISA and PCI */ Cirrus is still broken (test case: grub), debugging ATM. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux