From: Eric Sandeen <sandeen@redhat.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: Problems building xfsprogs
Date: Wed, 20 Jul 2011 13:32:16 -0500 [thread overview]
Message-ID: <4E271F30.6070102@redhat.com> (raw)
In-Reply-To: <20110720175918.GB17971@thunk.org>
On 07/20/2011 12:59 PM, Ted Ts'o wrote:
> I was trying to build xfsprogs in preparation for building xfstests in
> an hermetic environment (as opposed to depending on magic XFS headers
> being installed in /usr/include...)
>
> What I found first of all (building on Ubuntu 10.10) was
>
> a) "make configure" doesn't work until I patch the top-level Makefile:
>
> diff --git a/Makefile b/Makefile
> index c40fb2c..37973f5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -82,7 +82,7 @@ configure:
> libtoolize -c $(LIBTOOLIZE_INSTALL) -f
> cp include/install-sh .
> aclocal -I m4
> - autoconf
> + autoconf -I m4
>
> include/builddefs: configure
> ./configure $$LOCAL_CONFIGURE_OPTIONS
How does it fail? Works here(tm):
[sandeen@sandeen tmp]$ git clone
git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
[sandeen@sandeen xfsprogs-dev]$ cd xfsprogs-dev
[sandeen@sandeen xfsprogs-dev]$ make
...
aclocal -I m4
autoconf
./configure $LOCAL_CONFIGURE_OPTIONS
checking build system type... x86_64-redhat-linux-gnu
checking host system type... x86_64-redhat-linux-gnu
...
[CC] attrset.o
[LD] xfs_db
[sandeen@sandeen xfsprogs-dev]$
Wonder what the difference is...
> b) By default xfsprogs builds with DEBUG, and this causes building
> libxfs/xfs_ialloc.c to blow up since there a reference of
> xfs_stack_trace() which is undefined under a #ifdef DEBUG. The way to
> fix this is to build with DEBUG=-DNDEBUG, but it took me an hour or
> two figure this out....
Odd, libxfs/Makefile has:
DEBUG = -DNDEBUG
But to be honest, the DEBUG stuff has been a thorn in my side for Fedora
too, with the extra CFLAGS it sets, something gets goobered up by
default, and I build with -DNDEBUG for those packages too.
I just haven't sorted it out yet ....
So things to look into, but can you also describe how building xfstests
fails for you when you have all the ubuntu xfsprogs-related packages
installed?
-Eric
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@redhat.com>
To: Ted Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: Problems building xfsprogs
Date: Wed, 20 Jul 2011 13:32:16 -0500 [thread overview]
Message-ID: <4E271F30.6070102@redhat.com> (raw)
In-Reply-To: <20110720175918.GB17971@thunk.org>
On 07/20/2011 12:59 PM, Ted Ts'o wrote:
> I was trying to build xfsprogs in preparation for building xfstests in
> an hermetic environment (as opposed to depending on magic XFS headers
> being installed in /usr/include...)
>
> What I found first of all (building on Ubuntu 10.10) was
>
> a) "make configure" doesn't work until I patch the top-level Makefile:
>
> diff --git a/Makefile b/Makefile
> index c40fb2c..37973f5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -82,7 +82,7 @@ configure:
> libtoolize -c $(LIBTOOLIZE_INSTALL) -f
> cp include/install-sh .
> aclocal -I m4
> - autoconf
> + autoconf -I m4
>
> include/builddefs: configure
> ./configure $$LOCAL_CONFIGURE_OPTIONS
How does it fail? Works here(tm):
[sandeen@sandeen tmp]$ git clone
git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
[sandeen@sandeen xfsprogs-dev]$ cd xfsprogs-dev
[sandeen@sandeen xfsprogs-dev]$ make
...
aclocal -I m4
autoconf
./configure $LOCAL_CONFIGURE_OPTIONS
checking build system type... x86_64-redhat-linux-gnu
checking host system type... x86_64-redhat-linux-gnu
...
[CC] attrset.o
[LD] xfs_db
[sandeen@sandeen xfsprogs-dev]$
Wonder what the difference is...
> b) By default xfsprogs builds with DEBUG, and this causes building
> libxfs/xfs_ialloc.c to blow up since there a reference of
> xfs_stack_trace() which is undefined under a #ifdef DEBUG. The way to
> fix this is to build with DEBUG=-DNDEBUG, but it took me an hour or
> two figure this out....
Odd, libxfs/Makefile has:
DEBUG = -DNDEBUG
But to be honest, the DEBUG stuff has been a thorn in my side for Fedora
too, with the extra CFLAGS it sets, something gets goobered up by
default, and I build with -DNDEBUG for those packages too.
I just haven't sorted it out yet ....
So things to look into, but can you also describe how building xfstests
fails for you when you have all the ubuntu xfsprogs-related packages
installed?
-Eric
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-07-20 18:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 17:59 Problems building xfsprogs Ted Ts'o
2011-07-20 17:59 ` Ted Ts'o
2011-07-20 18:32 ` Eric Sandeen [this message]
2011-07-20 18:32 ` Eric Sandeen
2011-07-20 21:33 ` Ted Ts'o
2011-07-20 21:33 ` Ted Ts'o
2011-07-20 22:25 ` Greg Freemyer
2011-07-20 22:25 ` Greg Freemyer
2011-07-21 4:19 ` Ted Ts'o
2011-07-21 4:19 ` Ted Ts'o
2011-07-21 4:27 ` Ted Ts'o
2011-07-21 4:27 ` Ted Ts'o
2011-07-21 9:06 ` Christoph Hellwig
2011-07-21 16:31 ` Ted Ts'o
2011-07-21 16:31 ` Ted Ts'o
2011-07-21 22:57 ` Ted Ts'o
2011-07-21 22:57 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E271F30.6070102@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.