From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1QjfJF-0002Io-Fg for mharc-grub-devel@gnu.org; Wed, 20 Jul 2011 18:32:05 -0400 Received: from eggs.gnu.org ([140.186.70.92]:36718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjfJB-0002FR-9a for grub-devel@gnu.org; Wed, 20 Jul 2011 18:32:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjfJ7-0004Pu-G4 for grub-devel@gnu.org; Wed, 20 Jul 2011 18:32:01 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:37444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjfJ7-0004Pk-4x for grub-devel@gnu.org; Wed, 20 Jul 2011 18:31:57 -0400 Received: by wyg36 with SMTP id 36so575828wyg.0 for ; Wed, 20 Jul 2011 15:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type; bh=SOhJ6+o1rwjRdJZGL/Iu5JknFtbcXsHM/w/8RI+tvi0=; b=dYmzzOf/MPQ76iPByo/daw5gGtXyRMHj3K7dMd0GmQ6wAOqk3mBX6zTcTASpkAZj9i g/ZhquqxtU5tkuZfAqjDLGOoaB4tUajw1ONYOVORsFZA8wr/aHM1KbO18ZHo4XGsxfXW CI9LZcT1aDcM2yce6Cx+NXnA1Jc88q1mjcngg= Received: by 10.227.199.82 with SMTP id er18mr8201802wbb.63.1311201116019; Wed, 20 Jul 2011 15:31:56 -0700 (PDT) Received: from debian.x201.phnet (24-148.203-62.cust.bluewin.ch [62.203.148.24]) by mx.google.com with ESMTPS id gg16sm546516wbb.34.2011.07.20.15.31.53 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 20 Jul 2011 15:31:54 -0700 (PDT) Message-ID: <4E275757.6010601@gmail.com> Date: Thu, 21 Jul 2011 00:31:51 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110626 Iceowl/1.0b2 Icedove/3.1.11 MIME-Version: 1.0 To: Samuel Thibault Subject: Re: grub2 claims grub.cfg is out of partition References: <1311198605.2740.58.camel@x60> <4E27506F.6040702@gmail.com> <1311200227.2740.60.camel@x60> <20110720222808.GE7303@const.famille.thibault.fr> In-Reply-To: <20110720222808.GE7303@const.famille.thibault.fr> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigBD167AC6C6AE2F0DA5E55886" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.169 Cc: The development of GNU GRUB , 634799@bugs.debian.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2011 22:32:03 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBD167AC6C6AE2F0DA5E55886 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 21.07.2011 00:28, Samuel Thibault wrote: > tags 634799 + upstream patch > thanks > > Hello, > I've looked into it and arrived to the similar conclusion that the grub.cfg.new with inode =3D 0 is the problem. However I think no such entries should be there in the first place. In any case GRUB must be robust to such corruptions but I'd recommend to fix Hurd ext2 implementation as well. > Digging a bit with the issue, it seems grub2 does not ignore entries > with inode =3D=3D 0 while it should. See linux' ext2_readdir() in > fs/ext2/dir.c doing it: > > for ( ;(char*)de <=3D limit; de =3D ext2_next_entry(de)) { > if (de->inode) { > ... > } > } > > The attached patch fixes it. Shall I commit it to upstream grub2? > > Samuel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigBD167AC6C6AE2F0DA5E55886 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk4nV1cACgkQNak7dOguQgmPTQEAjdDAgFAKrRZCaEgn3adl2v8Q JjGpuCJaGtLDySTg/ecBAJCwcWrRV54JcbObjXYtVP5uH4teoj93CqskJ+n9ZRtl =YLTm -----END PGP SIGNATURE----- --------------enigBD167AC6C6AE2F0DA5E55886--