Please keep the list CC'ed.
On 21.07.2011 21:39, devkral wrote:
> sorry, I don't understand the uuid-LUKS logic of grub-probe and dmsetup
> doesn't support this check.
dmsetup info /dev/mapper/mycrypt gives:
...
UUID: CRYPT-LUKS1-xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-mycrypt_unformatted
And with grub-probe -t cryptodisk_uuid /mnt/crypt
you have:
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Where xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx is the unique UUID which is also
used in /dev/disk/by-uuid/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx, just
formatted differently.
The patch as is unnecessarily uses a heavily different codepath than
non-crypt ones. From maintainance point of view this is unacceptable.

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko