From: Fernando Gont <fernando@gont.com.ar>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, security@kernel.org, eugeneteo@kernel.sg,
netdev@vger.kernel.org, mpm@selenic.com
Subject: Re: [PATCH net-next-2.6] ipv6: make fragment identifications less predictable
Date: Thu, 21 Jul 2011 20:37:48 -0300 [thread overview]
Message-ID: <4E28B84C.2090305@gont.com.ar> (raw)
In-Reply-To: <20110721.151750.995903739612693126.davem@davemloft.net>
On 07/21/2011 07:17 PM, David Miller wrote:
>> Does it make sense to go in this direction rather than simply randomize
>> the IPv6 Fragment Identification?
>
> We could, but that's actually a bit more work.
>
> You have to avoid recycling IDs to the same destination host otherwise
> a retransmit could use the same ID and overlap with a previous set of
> frags, causing corruption.
>
> This means if you go the "pure random" route, you have to make sure
> that the 32-bit series produced by the random number generator is
> maximally long. This is why openbsd uses an ID generator based upon
> skip32 etc.
That scenario assumes packet reordering and/or packet loss. In that
case, and at those packet rates, I'd argue that you shoudn't be relying
on fragmentation, anyway (e.g., use PMTUD).
> So we have to look at it like a constrained resource, and therefore
> doing it on a per-destination basis like ipv4 makes a lot of sense.
>
> I think Eric's work is the way forward and I'll be applying his patches.
While I haven't had a chance to look at the patch yet, I was wondering
whether it defines both a separe "offset" and "counter" for each "flow".
(assuming that Identification values are selected as a result of ID =
offset + counter, where counter is incremented for each packet that is
sent, and offset is some value that depends on (src IP, dst ip)).
If you have separate "offset" for each flow, you solve the problem of
"predictable Identification values". However, if there's a single global
"counter", you're still subject of being exploited for an "idle scan").
Thanks,
--
Fernando Gont
e-mail: fernando@gont.com.ar || fgont@acm.org
PGP Fingerprint: 7809 84F5 322E 45C7 F1C9 3945 96EE A9EF D076 FFF1
next prev parent reply other threads:[~2011-07-21 23:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4E24BE94.7010301@gont.com.ar>
[not found] ` <1311082696.2375.26.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
[not found] ` <1311089463.2375.42.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
2011-07-19 20:47 ` [PATCH net-next-2.6] ipv6: make fragment identifications less predictable Eric Dumazet
2011-07-19 20:56 ` Matt Mackall
2011-07-20 6:50 ` Eric Dumazet
2011-07-20 8:25 ` Eric Dumazet
2011-07-20 10:27 ` Eric Dumazet
2011-07-21 1:32 ` Fernando Gont
2011-07-21 22:17 ` David Miller
2011-07-21 22:46 ` Rick Jones
2011-07-21 23:13 ` David Miller
2011-07-21 23:37 ` Fernando Gont [this message]
2011-07-22 0:07 ` David Miller
2011-07-22 0:34 ` Rick Jones
2011-07-22 1:18 ` Fernando Gont
2011-07-22 4:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E28B84C.2090305@gont.com.ar \
--to=fernando@gont.com.ar \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=eugeneteo@kernel.sg \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.