From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] libxl: added libxl compatibility with physical backend file for NetBSD Date: Fri, 22 Jul 2011 15:25:44 +0200 Message-ID: <4E297A58.6050205@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 07/22/11 14:38, Roger Pau Monn=C3=A9 wrote: > Hello, > > This patch fixes the problems described in a previous thread regarding > PV machines not booting on NetBSD with libxl toolstack. The patch also > prevents libxl from adding PCI entries to xenstore if there is no PCI > device configured in the guest. > > Regards, Roger. Thanks for this work. Just some coding style nits: - in xenbackend.c, replace C++ comments with C comments. - in libxl_device.c, start the preprecessor lines at column 1. Other than that: Acked-by: Christoph Egger Christoph --=20 ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632