From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] libxl: added libxl compatibility with physical backend file for NetBSD Date: Fri, 22 Jul 2011 15:46:04 +0200 Message-ID: <4E297F1C.5020304@amd.com> References: <1311341983.12772.66.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1311341983.12772.66.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 07/22/11 15:39, Ian Campbell wrote: > On Fri, 2011-07-22 at 13:38 +0100, Roger Pau Monn=C3=A9 wrote: >> Hello, >> >> This patch fixes the problems described in a previous thread regarding >> PV machines not booting on NetBSD with libxl toolstack. The patch also >> prevents libxl from adding PCI entries to xenstore if there is no PCI >> device configured in the guest. > > Thanks Roger. > > In general we prefer to see individual fixes split up into separate > patches for review and commit. Also please can you add to your ~/.hgrc: > [diff] > showfunc =3D True > It prints the function name in the hunk header which makes it easier to > review. > > The change to the hotplug script seems odd, if the "xtype" paramter is > not needed then just remove it altogether, otherwise we need to teach > libxl what to write. > > The PCI change looks good, although you might as well throw the for() > loop under the check too. > > "#ifdef" etc should be in column 0, but the content should be indented > normally. Ack. > The checks on LIBXL_DISK_FORMAT_EMPTY and S_ISBLK are not really relate= d > so I would not combine them even though the return is the same. > Otherwise the HAVE_PHY_BACKEND_FILE_SUPPORT change itself looks ok > > What is DONT_REMOVE_VBD_FROM_STORE for? Is this because xenbackendd doe= s > it for you or something else? The hotplug script invoked by xenbackendd removes the vbd entry via xenstored-rm. > Does your changed xenbackendd still work with xend? Oh, I see what the > hotplug script change was about now -- I guess just remove the commente= d > out line? Ack. Christoph --=20 ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632