From: Anthony Liguori <anthony@codemonkey.ws>
To: Brad <brad@comstyle.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] Guest agent does not build on OpenBSD
Date: Fri, 22 Jul 2011 14:05:48 -0500 [thread overview]
Message-ID: <4E29CA0C.1010101@codemonkey.ws> (raw)
In-Reply-To: <4E29C8C1.7000902@comstyle.com>
On 07/22/2011 02:00 PM, Brad wrote:
> On 22/07/11 2:28 PM, Blue Swirl wrote:
>> I get these errors on OpenBSD:
>> CC qga/guest-agent-commands.o
>> /src/qemu/qga/guest-agent-commands.c:14:20: warning: mntent.h: No such
>> file or directory
>> /src/qemu/qga/guest-agent-commands.c:17:22: warning: linux/fs.h: No
>> such file or directory
>> In file included from /src/qemu/qga/guest-agent-commands.c:19:
>> qapi-generated/qga-qmp-commands.h:36:7: warning: no newline at end of
>> file
>> /src/qemu/qga/guest-agent-commands.c: In function
>> 'guest_fsfreeze_build_mount_list':
>> /src/qemu/qga/guest-agent-commands.c:344: error: 'MOUNTED' undeclared
>> (first use in this function)
>> /src/qemu/qga/guest-agent-commands.c:344: error: (Each undeclared
>> identifier is reported only once
>> /src/qemu/qga/guest-agent-commands.c:344: error: for each function it
>> appears in.)
>> /src/qemu/qga/guest-agent-commands.c:354: warning: implicit
>> declaration of function 'setmntent'
>> /src/qemu/qga/guest-agent-commands.c:354: warning: nested extern
>> declaration of 'setmntent'
>> /src/qemu/qga/guest-agent-commands.c:354: warning: assignment makes
>> pointer from integer without a cast
>> /src/qemu/qga/guest-agent-commands.c:360: warning: implicit
>> declaration of function 'getmntent'
>> /src/qemu/qga/guest-agent-commands.c:360: warning: nested extern
>> declaration of 'getmntent'
>> /src/qemu/qga/guest-agent-commands.c:360: warning: assignment makes
>> pointer from integer without a cast
>> /src/qemu/qga/guest-agent-commands.c:367: error: dereferencing pointer
>> to incomplete type
>> /src/qemu/qga/guest-agent-commands.c:368: error: dereferencing pointer
>> to incomplete type
>> /src/qemu/qga/guest-agent-commands.c:369: error: dereferencing pointer
>> to incomplete type
>> /src/qemu/qga/guest-agent-commands.c:374: error: dereferencing pointer
>> to incomplete type
>> /src/qemu/qga/guest-agent-commands.c:375: error: dereferencing pointer
>> to incomplete type
>> /src/qemu/qga/guest-agent-commands.c:380: warning: implicit
>> declaration of function 'endmntent'
>> /src/qemu/qga/guest-agent-commands.c:380: warning: nested extern
>> declaration of 'endmntent'
>> /src/qemu/qga/guest-agent-commands.c: In function
>> 'qmp_guest_fsfreeze_freeze':
>> /src/qemu/qga/guest-agent-commands.c:436: error: 'FIFREEZE' undeclared
>> (first use in this function)
>> /src/qemu/qga/guest-agent-commands.c: In function
>> 'qmp_guest_fsfreeze_thaw':
>> /src/qemu/qga/guest-agent-commands.c:474: error: 'FITHAW' undeclared
>> (first use in this function)
>>
>> Maybe guest agent should be only built on supported hosts.
>
> *sigh* This was some pretty sloppy work that was commited with very
> little testing. The QAPI stuff that was commited also needs Python
> to build and no appropriate checks were added to the configure script
> to check for its presence and to allow the person building to point
> to appropriate Python binary instead of a hardcoded binary name in the
> Makefile.
>
Patches are certainly welcome.
Python in taken from path so you can certainly overload it.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2011-07-22 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 18:28 [Qemu-devel] Guest agent does not build on OpenBSD Blue Swirl
2011-07-22 19:00 ` Brad
2011-07-22 19:05 ` Anthony Liguori [this message]
2011-07-24 13:14 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E29CA0C.1010101@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=brad@comstyle.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.