From: Eliot Blennerhassett <eblennerhassett@audioscience.com>
Cc: linux@audioscience.com, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: Make snd_pcm_debug_name usable outside pcm_lib
Date: Sat, 23 Jul 2011 11:59:23 +1200 [thread overview]
Message-ID: <4E2A0EDB.50602@audioscience.com> (raw)
In-Reply-To: <s5hsjpy1upb.wl%tiwai@suse.de>
On 22/07/11 22:22, Takashi Iwai wrote:
> At Fri, 22 Jul 2011 22:05:26 +1200,
> linux@audioscience.com wrote:
>>
>> From: Eliot Blennerhassett <eblennerhassett@audioscience.com>
>>
>> Formatting a PCM name is useful for module debug too.
>> Add snd_prefix when making function public.
>>
>> Signed-off-by: Eliot Blennerhassett <eblennerhassett@audioscience.com>
>
> It'd need EXPORT_SYMBOL*() in addition.
>
> Or, this can be defined as an inline function.
> It's just a call of snprintf() with the passed arguments, after all.
Hmm. A side-effect of doing it this way is to make pcm.h depend on
core.h, (for substream->pcm->card->number) and there are some files that
include pcm.h but not core.h. E.g. pcsp_lib.c, ctvmem.c, oxygen_lib.c
(and quite a few other possible candidate)
Fix these, or go with the original non-inline version?
--
Eliot
next prev parent reply other threads:[~2011-07-22 23:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 10:05 [PATCH] ALSA: Make snd_pcm_debug_name usable outside pcm_lib linux
2011-07-22 10:22 ` Takashi Iwai
2011-07-22 23:59 ` Eliot Blennerhassett [this message]
2011-07-23 0:36 ` [PATCH v2] " linux
2011-07-24 11:38 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2A0EDB.50602@audioscience.com \
--to=eblennerhassett@audioscience.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux@audioscience.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.