From: Jens Axboe <jaxboe@fusionio.com>
To: Daniel Farina <daniel@heroku.com>
Cc: Chris Worley <worleys@gmail.com>, fio@vger.kernel.org
Subject: Re: fio: when not using a job file, timeouts are not applied
Date: Sat, 23 Jul 2011 13:43:10 +0200 [thread overview]
Message-ID: <4E2AB3CE.6030700@fusionio.com> (raw)
In-Reply-To: <CAAZKuFZ2WdK8YkLuo9ayyHe4=pv8+F7Tm1-cBO=JiQtuW5tLtA@mail.gmail.com>
On 2011-07-19 02:21, Daniel Farina wrote:
> On Mon, Jul 18, 2011 at 5:19 PM, Chris Worley <worleys@gmail.com> wrote:
>> Do you mean to be using --timeout or --runtime?
>
> --timeout. It's pretty clear the semantics using a job file and those
> without a job file are not the same, or are you not able to reproduce
> this?
Sorry for the late reply, I'm on vacation. This should fix it.
diff --git a/init.c b/init.c
index 85bd0f7..98e10f7 100644
--- a/init.c
+++ b/init.c
@@ -47,7 +47,6 @@ int warnings_fatal = 0;
int write_bw_log = 0;
int read_only = 0;
-static int def_timeout;
static int write_lat_log;
static int prev_group_jobs;
@@ -951,8 +950,6 @@ static int fill_def_thread(void)
* fill default options
*/
fio_fill_default_options(&def_thread);
-
- def_thread.o.timeout = def_timeout;
return 0;
}
@@ -1160,7 +1157,7 @@ static int parse_cmd_line(int argc, char *argv[])
smalloc_pool_size = atoi(optarg);
break;
case 't':
- def_timeout = atoi(optarg);
+ def_thread.o.timeout = atoi(optarg);
break;
case 'l':
write_lat_log = 1;
--
Jens Axboe
next prev parent reply other threads:[~2011-07-23 11:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 19:01 fio: when not using a job file, timeouts are not applied Daniel Farina
2011-07-18 19:35 ` Chris Worley
2011-07-18 21:46 ` Daniel Farina
2011-07-18 23:11 ` Chris Worley
2011-07-18 23:28 ` Daniel Farina
2011-07-18 23:49 ` Chris Worley
2011-07-19 0:02 ` Daniel Farina
2011-07-19 0:19 ` Chris Worley
2011-07-19 0:21 ` Daniel Farina
2011-07-23 11:43 ` Jens Axboe [this message]
2011-07-19 0:22 ` Chris Worley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2AB3CE.6030700@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=daniel@heroku.com \
--cc=fio@vger.kernel.org \
--cc=worleys@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.