Re: [Qemu-devel] [PATCH] guest agent: qemu-ga daemon

[Anthony Liguori <anthony@codemonkey.ws>]

On 07/23/2011 11:06 AM, Michael Roth wrote:
> On 07/23/2011 05:07 AM, Alexander Graf wrote:
>>
>> On 20.07.2011, at 22:19, Michael Roth wrote:
>>
>>> This is the actual guest daemon, it listens for requests over a
>>> virtio-serial/isa-serial/unix socket channel and routes them through
>>> to dispatch routines, and writes the results back to the channel in
>>> a manner similar to QMP.
>>>
>>> A shorthand invocation:
>>>
>>> qemu-ga -d
>>>
>>> Is equivalent to:
>>>
>>> qemu-ga -m virtio-serial -p /dev/virtio-ports/org.qemu.guest_agent.0 \
>>> -f /var/run/qemu-ga.pid -d
>>>
>>> Signed-off-by: Michael Roth<mdroth@linux.vnet.ibm.com>
>>
>> A rebase on top of current HEAD gave me the following on openSUSE 11.1
>> PPC:
>>
>>
>> agraf@lychee:/home/agraf/release/qemu> make
>> CC qemu-ga.o
>> qemu-ga.c:40: error: expected specifier-qualifier-list before ‘GSocket’

GIO is fairly new.  It may not be available on openSUSE.

Mike, you probably need to do a configure test for GIO and if it's not 
present, don't build qemu-ga.

Maybe look at just using GIOChannels which have been around much longer 
than GSocket.

>> qga/guest-agent-commands.c: In function ‘qmp_guest_fsfreeze_freeze’:
>> qga/guest-agent-commands.c:443: error: ‘FIFREEZE’ undeclared (first
>> use in this function)
>> qga/guest-agent-commands.c:443: error: (Each undeclared identifier is
>> reported only once
>> qga/guest-agent-commands.c:443: error: for each function it appears in.)
>> qga/guest-agent-commands.c: In function ‘qmp_guest_fsfreeze_thaw’:
>> qga/guest-agent-commands.c:481: error: ‘FITHAW’ undeclared (first use
>> in this function)

The kernel probably doesn't implement FIFREEZE.  You need to do a 
configure test and set CONFIG_FSFREEZE appropriately.  I anticipated 
this and that's why I added CONFIG_FSFREEZE and didn't just do __linux__.

Regards,

Anthony Liguori