From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkfPJ-0005zd-75 for qemu-devel@nongnu.org; Sat, 23 Jul 2011 12:50:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkfPI-0006fR-1y for qemu-devel@nongnu.org; Sat, 23 Jul 2011 12:50:29 -0400 Received: from mail-pz0-f43.google.com ([209.85.210.43]:39071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkfPH-0006fN-SB for qemu-devel@nongnu.org; Sat, 23 Jul 2011 12:50:28 -0400 Received: by pzk1 with SMTP id 1so5806644pzk.30 for ; Sat, 23 Jul 2011 09:50:26 -0700 (PDT) Message-ID: <4E2AFBCE.90406@codemonkey.ws> Date: Sat, 23 Jul 2011 11:50:22 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1308081188-19695-1-git-send-email-rth@twiddle.net> In-Reply-To: <1308081188-19695-1-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH, v2] vga: Fix type of lfb/map_addr/end. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Jan Kiszka , qemu-devel@nongnu.org On 06/14/2011 02:53 PM, Richard Henderson wrote: > These addresses have been passed through pci_to_cpu_addr, > and thus need to be full target_phys_addr_t. > > Signed-off-by: Richard Henderson > Cc: Jan Kiszka Applied. Thanks. Regards, Anthony Liguori > --- > > V1->V2: > lfb_addr/end also widened to guest address width. > > hw/vga_int.h | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/vga_int.h b/hw/vga_int.h > index d2811bd..eee91a8 100644 > --- a/hw/vga_int.h > +++ b/hw/vga_int.h > @@ -106,13 +106,13 @@ typedef void (* vga_update_retrace_info_fn)(struct VGACommonState *s); > typedef struct VGACommonState { > uint8_t *vram_ptr; > ram_addr_t vram_offset; > + target_phys_addr_t lfb_addr; > + target_phys_addr_t lfb_end; > + target_phys_addr_t map_addr; > + target_phys_addr_t map_end; > uint32_t vram_size; > - uint32_t lfb_addr; > - uint32_t lfb_end; > - uint32_t map_addr; > - uint32_t map_end; > - uint32_t lfb_vram_mapped; /* whether 0xa0000 is mapped as ram */ > uint32_t latch; > + uint32_t lfb_vram_mapped; /* whether 0xa0000 is mapped as ram */ > uint8_t sr_index; > uint8_t sr[256]; > uint8_t gr_index;