All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mihai Moldovan <ionic@ionic.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Subject: [PATCH] fix fat utf8 iocharset warning message
Date: Sun, 24 Jul 2011 15:37:25 +0200	[thread overview]
Message-ID: <4E2C2015.6090200@ionic.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

The fat_msg function already formats the given message and appends
a newline to it - we don't need to do this in the passed message
string as well, or will end up with a blank line printed in the
kernel log ring buffer.

Signed-off-by: Mihai Moldovan <ionic@ionic.de>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---
 fs/fat/inode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 5942fec..46530a1 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1190,7 +1190,7 @@ out:
     if (!strcmp(opts->iocharset, "utf8")) {
         fat_msg(sb, KERN_ERR, "utf8 is not a recommended IO charset"
                " for FAT filesystems, filesystem will be "
-               "case sensitive!\n");
+               "case sensitive!");
     }
 
     /* If user doesn't specify allow_utime, it's initialized from dmask. */
-- 
1.7.6


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4369 bytes --]

             reply	other threads:[~2011-07-24 13:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-24 13:37 Mihai Moldovan [this message]
2011-07-24 17:22 ` [PATCH] fix fat utf8 iocharset warning message Jesper Juhl
2011-07-24 18:19   ` Mihai Moldovan
2011-07-25 20:20     ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E2C2015.6090200@ionic.de \
    --to=ionic@ionic.de \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.