All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v3)
Date: Sun, 24 Jul 2011 20:15:19 +0200	[thread overview]
Message-ID: <4E2C6137.6070501@redhat.com> (raw)
In-Reply-To: <4E296FAD.8070101@redhat.com>

Hi,

On 07/22/2011 02:40 PM, Gerd Hoffmann wrote:
>> ACK.
>>
>> Another option would be to not call the state callback for the vdagent
>> subtype from spice-server, because like you say it ignores the continued
>> communication between the agent and the server. Then you could remove
>> the subtype check.
>
> We can even #ifdef the check using SPICE_SERVER_VERSION once the spice-server change is committed, and in a year or so we can raise the minimum required spice-server version and remove some #ifdef clutter.
>

Yeah that is more or less what I proposed in the last mail in the spice-devel
mailinglist thread, I'm glad you agree. I'll prepare a patch to remove
the state calls from the spice-server vdagent handling.

Regards,

Hans

      reply	other threads:[~2011-07-24 18:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22  9:40 [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v3) Hans de Goede
2011-07-22 12:25 ` Alon Levy
2011-07-22 12:40   ` Gerd Hoffmann
2011-07-24 18:15     ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E2C6137.6070501@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.