From: Pavel Roskin <proski@gnu.org>
To: unlisted-recipients:; (no To-header on input)
Cc: RafałMiłecki <zajec5@gmail.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] b43: fix invalid memory access in b43_ssb_remove()
Date: Mon, 25 Jul 2011 12:26:56 -0400 [thread overview]
Message-ID: <4E2D9950.1080404@gnu.org> (raw)
In-Reply-To: <20110722220016.15648.30628.stgit@mj.roinet.com>
On 07/22/2011 06:07 PM, Pavel Roskin wrote:
> wldev is freed in b43_one_core_detach() and should not be accessed after
> that call. Keep wldev->dev in a local variable.
>
> Signed-off-by: Pavel Roskin<proski@gnu.org>
> ---
>
> Linux 3.0 is not affected. The bug was introduced in 482f0538.
P.S. This needs to be propagated to Linux 3.1.
> - b43_one_core_detach(wldev->dev);
> + b43_one_core_detach(dev);
As a long term solution, we probably want a function that takes wldev
and has "free" in its name, so that the effect is clear.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2011-07-25 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 22:07 [PATCH] b43: fix invalid memory access in b43_ssb_remove() Pavel Roskin
2011-07-25 16:26 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2D9950.1080404@gnu.org \
--to=proski@gnu.org \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.