Hi Jeevaka, On 07/25/2011 01:15 PM, Jeevaka Badrappan wrote: > Hi, > > This patch set fixes the review comments. > > If the modem is able to setup the call, then the alpha id will be freed when the > initiated call ends. > > If the modem is not able to setup the call due to some reason, then the memory > allocated for alpha id and dial request are freed when the command end/session > end is received. > I went ahead and applied both of these patches. I did do some minor refactoring afterwards, please test and let me know whether I broke something. > Also, noticed there is a break missing in the ofono_stk_proactive_command_handled_notify > for STK_COMMAND_TYPE_SEND_SS case. Fix for that will be provided as a separate patch. I went ahead and fixed this as well. > > Note: This version of the patch is not tested. > > Thanks and Regards, > Jeevaka > Regards, -Denis