From: Jens Axboe <jaxboe@fusionio.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: block: BUG: using smp_processor_id() in preemptible [00000000] code
Date: Tue, 26 Jul 2011 07:26:09 +0200 [thread overview]
Message-ID: <4E2E4FF1.1010103@fusionio.com> (raw)
In-Reply-To: <CACVXFVOYYZt-XfbPx_dEOm9qOAuGqmviH4TdXxg6xTrrB8PaMQ@mail.gmail.com>
On 2011-07-26 06:49, Ming Lei wrote:
> Hi,
>
> The bug is observed in -next-20110725, follows the stack trace[1], and
> seems the attachment patch can fix the bug.
Does this work, too? We don't necessarily need the CPU stable, but
spewing debug output isn't very nice.
diff --git a/block/blk-core.c b/block/blk-core.c
index f8cb099..f925581 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -1283,7 +1283,7 @@ get_rq:
if (test_bit(QUEUE_FLAG_SAME_COMP, &q->queue_flags) ||
bio_flagged(bio, BIO_CPU_AFFINE))
- req->cpu = smp_processor_id();
+ req->cpu = raw_smp_processor_id();
plug = current->plug;
if (plug) {
--
Jens Axboe
next prev parent reply other threads:[~2011-07-26 5:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 4:49 block: BUG: using smp_processor_id() in preemptible [00000000] code Ming Lei
2011-07-26 5:26 ` Jens Axboe [this message]
2011-07-26 6:22 ` Ming Lei
2011-07-26 13:04 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2E4FF1.1010103@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.