From: Jonathan Cameron <jic23@cam.ac.uk>
To: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"device-drivers-devel@blackfin.uclinux.org"
<device-drivers-devel@blackfin.uclinux.org>
Subject: Re: [PATCH 2/7] staging:iio: remove specific chrdev for event reading. Get fd from ioctl on buffer.
Date: Tue, 26 Jul 2011 09:48:48 +0100 [thread overview]
Message-ID: <4E2E7F70.2030102@cam.ac.uk> (raw)
In-Reply-To: <544AC56F16B56944AEC3BD4E3D5917714300119677@LIMKCMBX1.ad.analog.com>
On 07/26/11 09:36, Hennerich, Michael wrote:
> Jonathan Cameron wrote on 2011-07-25:
>> Change suggested by Arnd Bergmann.
>>
>> No real reason to have two chrdevs per device. This step merges them
>> into one.
>> Currently this means that events will only work on devices with
>> buffers. THat will be remedied shortly.
>
> Will there be am iio:event instead?
> Or iio:buffer even if no buffer and we need to get the iio:event through the anon fds?
Nope. There is only one and it is called iio:deviceX. Some stub functions should
(if I have gotten it right) ensure that you can have events and/or buffers.
Note that isn't as you've noticed the case mid way through this set. Couldn't see
a cleaner way of doing this. It only all should work after patch 5.
>
>> V2: set name for event attribute groups. Otherwise they all sorts of
>> fun occurs on dynamic channel event attribute creation.
>>
>> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
> Acked-by: Michael Hennerich <michael.hennerich@analog.com>
>> ---
>> drivers/staging/iio/accel/sca3000_core.c | 1 +
>> drivers/staging/iio/adc/ad7150.c | 1 +
>> drivers/staging/iio/adc/ad7745.c | 1 +
>> drivers/staging/iio/adc/ad7816.c | 1 +
>> drivers/staging/iio/adc/ad799x_core.c | 2 +
>> drivers/staging/iio/adc/adt7310.c | 2 +
>> drivers/staging/iio/adc/adt7410.c | 2 +
>> drivers/staging/iio/adc/adt75.c | 1 +
>> drivers/staging/iio/adc/max1363_core.c | 4 +-
>> drivers/staging/iio/addac/adt7316.c | 2 +
>> drivers/staging/iio/chrdev.h | 1 +
>> drivers/staging/iio/dac/ad5504.c | 1 +
>> drivers/staging/iio/iio.h | 1 +
>> drivers/staging/iio/industrialio-core.c | 174
>> ++++++++++------------
>> --------
>
> Greetings,
> Michael
>
> --
> Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
> Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif
>
>
>
>
next prev parent reply other threads:[~2011-07-26 8:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 13:18 [PATCH 0/7 V2] blue part 5: IIO: Reduce to 1 the number of chrdevs per device Jonathan Cameron
2011-07-25 13:18 ` [PATCH 1/7] staging:iio:chrdev.h rationalization Jonathan Cameron
2011-07-25 13:18 ` [PATCH 2/7] staging:iio: remove specific chrdev for event reading. Get fd from ioctl on buffer Jonathan Cameron
2011-07-26 8:36 ` Hennerich, Michael
2011-07-26 8:48 ` Jonathan Cameron [this message]
2011-07-25 13:18 ` [PATCH 3/7] ioctl region for IIO Jonathan Cameron
2011-07-25 13:18 ` [PATCH 4/7] staging:iio: squash chrdev handler remains into users Jonathan Cameron
2011-07-25 13:18 ` [PATCH 5/7] staging:iio: push the main buffer chrdev down to the top level Jonathan Cameron
2011-07-26 8:22 ` Hennerich, Michael
2011-07-29 16:09 ` Jonathan Cameron
2011-07-25 13:18 ` [PATCH 6/7] staging:iio: remove now defunct header definitions and add some statics Jonathan Cameron
2011-07-25 13:18 ` [PATCH 7/7] staging:iio:Documentation sysfs-bus-iio update for chrdev merge Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2E7F70.2030102@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=Michael.Hennerich@analog.com \
--cc=arnd@arndb.de \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.