All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx53: use CONFIG_SYS_L2CACHE_OFF in config file
Date: Tue, 26 Jul 2011 11:21:28 +0200	[thread overview]
Message-ID: <4E2E8718.3070801@denx.de> (raw)
In-Reply-To: <1311668750-5471-1-git-send-email-jason.hui@linaro.org>

On 07/26/2011 10:25 AM, Jason Liu wrote:
> CONFIG_L2_OFF is obsolete after the following commit:
> 
> e47f2db5371047eb9bcd115fee084e6a8a92a239
> armv7: rename cache related CONFIG flags
> Replace the cache related CONFIG flags with more meaningful
> names. Following are the changes:
> CONFIG_L2_OFF	     -> CONFIG_SYS_L2CACHE_OFF
> 
> But the above commit does not clean up all the mx53 board config file.
> This patch does it by using CONFIG_SYS_L2CACHE_OFF instead of _L2_OFF
> 

Hi Jason,

I agree  that CONFIG_L2_OFF is obsolete and must be removed. However, I
do not see any application of CONFIG_SYS_L2CACHE_OFF.

If I grep into u-boot code, this config is not used at all for i.MX.
Indeed, I can find application for OMAP boards:

arch/arm/cpu/armv7/omap3/board.c:#ifndef CONFIG_SYS_L2CACHE_OFF
arch/arm/cpu/armv7/omap3/board.c:#ifndef CONFIG_SYS_L2CACHE_OFF
arch/arm/cpu/armv7/s5pc1xx/cache.S:#ifndef CONFIG_SYS_L2CACHE_OFF
arch/arm/cpu/armv7/omap4/board.c:#ifndef CONFIG_SYS_L2CACHE_OFF

So this setup is usefulness, I think.

By the way (and I know it is not the same topic), do you mean maybe
CONFIG_SYS_DCACHE_OFF ? Have you read the thread related to cache
problems on MX51 ? Maybe we have to disable D_CACHE until we find a fix
for the drivers. What do you mean ?

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2011-07-26  9:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26  8:25 [U-Boot] [PATCH] mx53: use CONFIG_SYS_L2CACHE_OFF in config file Jason Liu
2011-07-26  9:21 ` Stefano Babic [this message]
2011-07-26  9:44   ` Jason Hui
2011-07-28  5:56     ` Jason Liu
2011-07-28  6:32       ` Stefano Babic
2011-07-28 10:22         ` Jason Liu
2011-07-28 10:40           ` Stefano Babic
2011-07-26  9:34 ` Wolfgang Denk
2011-07-27  2:36   ` Jason Liu
  -- strict thread matches above, loose matches on Subject: below --
2011-07-26  8:17 Jason Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E2E8718.3070801@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.