From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QliDp-00048m-1C for qemu-devel@nongnu.org; Tue, 26 Jul 2011 10:03:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QliDn-0007FK-Ep for qemu-devel@nongnu.org; Tue, 26 Jul 2011 10:02:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QliDn-0007FG-7m for qemu-devel@nongnu.org; Tue, 26 Jul 2011 10:02:55 -0400 Message-ID: <4E2EC9B6.8060105@redhat.com> Date: Tue, 26 Jul 2011 16:05:42 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1311684710-27074-1-git-send-email-coreyb@linux.vnet.ibm.com> <20110726130211.GA2853@lst.de> In-Reply-To: <20110726130211.GA2853@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: libvir-list@redhat.com, aliguori@us.ibm.com, Corey Bryant , qemu-devel@nongnu.org, tchicks@us.ibm.com Am 26.07.2011 15:02, schrieb Christoph Hellwig: > I have to say I really hate it. We've been working hard on getting rid > of special cases in the qemu block layer, and this sprinkles them all > over. I'd recommend to fix your security model instead. I think the problem here is more with the implementation that with the intention. I agree that you just can't do this. A patch adding support for a fd: protocol should touch block/fd.c and nothing else. You can add some supporting patches that extend the generic block layer to support e.g. formats that can't reopen. However, if you touch the code of other block drivers, you're doing it wrong. Kevin