From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] xen_mapcache: remove unused variable
Date: Tue, 26 Jul 2011 10:54:48 -0400 [thread overview]
Message-ID: <4E2ED538.5050200@linux.vnet.ibm.com> (raw)
In-Reply-To: <3f56b8e8461282d8942c88b616c09907854f8b23.1310400716.git.quintela@redhat.com>
On 07/11/2011 12:15 PM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela<quintela@redhat.com>
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Been pointed to this patch after having posted the same.
Stefan
> ---
> xen-mapcache.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/xen-mapcache.c b/xen-mapcache.c
> index fac47cd..e2e324d 100644
> --- a/xen-mapcache.c
> +++ b/xen-mapcache.c
> @@ -232,7 +232,7 @@ uint8_t *qemu_map_cache(target_phys_addr_t phys_addr, target_phys_addr_t size, u
>
> ram_addr_t qemu_ram_addr_from_mapcache(void *ptr)
> {
> - MapCacheEntry *entry = NULL, *pentry = NULL;
> + MapCacheEntry *entry = NULL;
> MapCacheRev *reventry;
> target_phys_addr_t paddr_index;
> target_phys_addr_t size;
> @@ -258,7 +258,6 @@ ram_addr_t qemu_ram_addr_from_mapcache(void *ptr)
>
> entry =&mapcache->entry[paddr_index % mapcache->nr_buckets];
> while (entry&& (entry->paddr_index != paddr_index || entry->size != size)) {
> - pentry = entry;
> entry = entry->next;
> }
> if (!entry) {
next prev parent reply other threads:[~2011-07-26 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 16:15 [Qemu-devel] [PATCH 0/2] Yet more gcc warnings fixes Juan Quintela
2011-07-11 16:15 ` [Qemu-devel] [PATCH 1/2] xen_mapcache: remove unused variable Juan Quintela
2011-07-12 10:19 ` Stefano Stabellini
2011-07-26 14:54 ` Stefan Berger [this message]
2011-07-27 9:03 ` Stefan Hajnoczi
2011-07-11 16:15 ` [Qemu-devel] [PATCH 2/2] syscall: pselect arg_sigsize variable was write only Juan Quintela
2011-07-11 16:50 ` Peter Maydell
2011-07-11 19:35 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2ED538.5050200@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.