From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qljg7-0000nQ-Qf for qemu-devel@nongnu.org; Tue, 26 Jul 2011 11:36:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qljg6-0000eP-Sa for qemu-devel@nongnu.org; Tue, 26 Jul 2011 11:36:15 -0400 Received: from mel.act-europe.fr ([194.98.77.210]:32980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qljg6-0000eA-J0 for qemu-devel@nongnu.org; Tue, 26 Jul 2011 11:36:14 -0400 Message-ID: <4E2EDEDE.1080800@adacore.com> Date: Tue, 26 Jul 2011 17:35:58 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1308832303-24205-1-git-send-email-berrange@redhat.com> <1308832303-24205-3-git-send-email-berrange@redhat.com> <4E2EDB30.1010804@adacore.com> <20110726152945.GI19481@redhat.com> In-Reply-To: <20110726152945.GI19481@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] Introduce a 'client_add' monitor command accepting an open FD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org On 26/07/2011 17:29, Daniel P. Berrange wrote: > On Tue, Jul 26, 2011 at 05:20:16PM +0200, Fabien Chouteau wrote: >> On 23/06/2011 14:31, Daniel P. Berrange wrote: >>> Allow client connections for VNC and socket based character >>> devices to be passed in over the monitor using SCM_RIGHTS. >>> >> >> Hello Daniel, >> >> I'm a little bit late but it seems that there's a build error with this patch >> when VNC is disabled. >> >> $./configure --target-list=ppc-softmmu --disable-vnc >> ... >> $ make >> ... >> monitor.o: In function `add_graphics_client': >> .../monitor.c:1205: undefined reference to `vnc_display_add_client' > > There was already a patch posted yesterday which should fix this > problem: > > Subject: [PATCH] monitor: fix build breakage with --disable-vnc > OK, thanks. Sorry about the noise... -- Fabien Chouteau