From: Jeff Mitchell <jmitchell@ll.mit.edu>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] bb-matrix.sh: check for the existence of time
Date: Tue, 26 Jul 2011 18:50:20 -0400 [thread overview]
Message-ID: <4E2F44AC.4040803@ll.mit.edu> (raw)
In-Reply-To: <4E2F429E.5030607@linux.intel.com>
On 07/26/2011 06:41 PM, Darren Hart wrote:
>
> Hi Jeff,
>
> Thanks for the patch. A couple points of feedback below:
>
> On 07/26/2011 02:57 PM, Jeff Mitchell wrote:
>> What an existential subject. The patch is quite self-explanatory.
>
> Well, there is almost always a need for commit log beyond just the
> subject. The only exception might be "whitespace fixes only" or
> "spelling fixes only".
I did write a commit log, but git-format-patch turned it into the
subject of the attached patch. No, I haven't used git-format-patch
before :-) (I've been fortunate to have been able to avoid it for many
years now.)
> Also, while it is tempting to squeeze in typo fixes and such with a
> functional patch, unless they are in the code you are changing anyway,
> they should be sent as separate patches.
Given the triviality of both changes I didn't think this would be an issue.
--Jeff
prev parent reply other threads:[~2011-07-26 22:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 21:57 [PATCH] bb-matrix.sh: check for the existence of time Jeff Mitchell
2011-07-26 22:41 ` Jeff Mitchell
2011-07-26 22:41 ` Darren Hart
2011-07-26 22:50 ` Jeff Mitchell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2F44AC.4040803@ll.mit.edu \
--to=jmitchell@ll.mit.edu \
--cc=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.