From: Michael J Gruber <git@drmicha.warpmail.net>
To: Reuben Thomas <rrt@sc3d.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [RFC/PATCH] commit: allow partial commits with relative paths
Date: Wed, 27 Jul 2011 11:53:40 +0200 [thread overview]
Message-ID: <4E2FE024.2030204@drmicha.warpmail.net> (raw)
In-Reply-To: <CAOnWdojgxZNs4qyEG55URScqOGb6k5e6Mh_B3By6Lj6SpN9L9g@mail.gmail.com>
Reuben Thomas venit, vidit, dixit 27.07.2011 11:45:
> On 27 July 2011 09:22, Michael J Gruber <git@drmicha.warpmail.net> wrote:
>> Junio C Hamano venit, vidit, dixit 25.07.2011 21:02:
>>> Michael J Gruber <git@drmicha.warpmail.net> writes:
>>>
>>> Also what is the "same
>>> problem"?
>>
>> The one reported by the OP for commit:
>>
>> git rm ../a
>> git commit -m "blurb" ../a
>> error: pathspec '../a' did not match any file(s) known to git.
>
> Actually, this is not what I reported. This explains why I couldn't
> quite understand the direction this thread took. Look again:
>
> $ cat ~/reportbug-git
> $ git rm -f ../INSTALL
> rm 'INSTALL'
> $ git ci -m "INSTALL is now provided by gnulib." ../INSTALL
> error: pathspec 'ALL' did not match any file(s) known to git.
> $ cd ..
> $ git ci -m "INSTALL is now provided by gnulib." INSTALL
> [master 0895314] INSTALL is now provided by gnulib.
> 1 files changed, 0 insertions(+), 1 deletions(-)
> delete mode 120000 INSTALL
>
> The thing I didn't understand is that I tried to check in ../INSTALL,
> but git complained about pathspec 'ALL'.
Well, you didn't say so, did you?
Also, we don't know what subdir you were doing this in, but I bet it has
a 7-character name...
I can't reproduce that name truncation with a current git, btw. (So I
won't bother bisecting where we removed a spurious offset by "prefix".)
In any case, I still think git should allow partial commits with staged
deletions from within a subdir, which is what my patch is about.
Michael
next prev parent reply other threads:[~2011-07-27 9:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-23 20:25 Possible bug Reuben Thomas
2011-07-25 7:42 ` [RFC/PATCH] commit: allow partial commits with relative paths Michael J Gruber
2011-07-25 19:02 ` Junio C Hamano
2011-07-25 19:32 ` Junio C Hamano
2011-07-27 8:22 ` Michael J Gruber
2011-07-27 9:45 ` Reuben Thomas
2011-07-27 9:53 ` Michael J Gruber [this message]
2011-07-27 10:00 ` Reuben Thomas
2011-07-27 10:19 ` John Szakmeister
2011-07-27 11:56 ` [RFC/PATCH] ls-files: fix pathspec display on error Michael J Gruber
2011-07-29 13:03 ` Clemens Buchacher
2011-08-01 0:01 ` Junio C Hamano
2011-08-01 18:03 ` [PATCH] test ls-files with relative paths Clemens Buchacher
2011-08-01 20:14 ` Junio C Hamano
2011-08-01 21:19 ` [PATCH v2] ls-files: fix pathspec display on error Clemens Buchacher
2011-08-01 22:30 ` Junio C Hamano
2011-07-28 7:38 ` [RFC/PATCH] commit: allow partial commits with relative paths Erik Faye-Lund
2011-07-27 15:37 ` Junio C Hamano
2011-07-27 15:41 ` Junio C Hamano
2011-07-27 15:50 ` Michael J Gruber
2011-07-29 13:35 ` [PATCH] " Clemens Buchacher
2011-07-30 16:45 ` Michael J Gruber
2011-07-30 17:00 ` Clemens Buchacher
2011-07-30 17:04 ` Michael J Gruber
2011-07-30 17:13 ` [PATCH v2] " Clemens Buchacher
2011-08-01 0:05 ` Junio C Hamano
2011-08-02 21:31 ` Junio C Hamano
2011-08-03 19:28 ` Clemens Buchacher
2011-08-03 22:07 ` Junio C Hamano
2011-09-04 10:41 ` renaming pathspec_prefix (was: Re: [PATCH v2] commit: allow partial commits with relative paths) Clemens Buchacher
2011-09-04 10:41 ` [PATCH 1/3] remove prefix argument from pathspec_prefix Clemens Buchacher
2011-09-06 19:02 ` Junio C Hamano
2011-09-06 19:58 ` Junio C Hamano
2011-09-08 7:12 ` Clemens Buchacher
2011-09-08 16:51 ` Junio C Hamano
2011-09-04 10:42 ` [PATCH 2/3] consolidate pathspec_prefix and common_prefix Clemens Buchacher
2011-09-04 10:42 ` [PATCH 3/3] rename pathspec_prefix -> common_prefix and move to dir.[ch] Clemens Buchacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2FE024.2030204@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.