From: Josef Bacik <josef@redhat.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Chris Mason <chris.mason@oracle.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] btrfs: btrfs_calc_avail_data_space cope with no read/write devices
Date: Wed, 27 Jul 2011 10:25:17 -0400 [thread overview]
Message-ID: <4E301FCD.6060202@redhat.com> (raw)
In-Reply-To: <1311764491-5687-1-git-send-email-apw@canonical.com>
On 07/27/2011 07:01 AM, Andy Whitcroft wrote:
> When we mount a btrfs filesystem from read-only media there will be no
> read/write devices; for example mounting an SD card with its lock enabled.
> This triggers an immediate BUG during mount:
>
> kernel BUG at .../fs/btrfs/super.c:984!
>
> This is triggered by statfs when calculating the free space in the
> filesytem. We bug if the number of read/write devices is 0.
>
> It seems more appropriate to indicate we have no writable space. Note
> that this does make df return 0 free blocks on a read-only device.
> Whether that is reasonable is debatable.
No it's not, it's wrong. We should just look at the devices in general
and not just the rw_devices. We can still get the right info out, if
you mount a ext* fs ro you still get the right output from df. Thanks,
Josef
next prev parent reply other threads:[~2011-07-27 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 11:01 [PATCH 1/1] btrfs: btrfs_calc_avail_data_space cope with no read/write devices Andy Whitcroft
2011-07-27 14:25 ` Josef Bacik [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-27 10:59 Andy Whitcroft
2011-07-27 11:09 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E301FCD.6060202@redhat.com \
--to=josef@redhat.com \
--cc=apw@canonical.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.