All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Schwarz <simonschwarzcor@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] preloader_console_init()
Date: Wed, 27 Jul 2011 17:02:50 +0200	[thread overview]
Message-ID: <4E30289A.7010101@gmail.com> (raw)
In-Reply-To: <CAM=4YESUyu0vcd9CVse0_vSwnyCDQpS27Fodc3eBknv50tQSMA@mail.gmail.com>

Hi Aneesh,

On 07/27/2011 04:39 PM, V, Aneesh wrote:
> Hi Simon,
>
> On Mon, Jul 25, 2011 at 8:36 PM, Simon Schwarz
> <simonschwarzcor@googlemail.com>  wrote:
>> Hi Aneesh,
>>
>> I'am nearly done with OMAP3 - I think I can release the patch today.
>>
>> I have just one problem left:
>> You implemented preloader_console_init() in omap-common to call
>> setup_clocks_for_console(). This is a OMAP4 specific call - OMAP3 only has
>> per_clocks_init() - which inits a bunch of clocks.
>
> Sorry. I was on a short travel and didn't have mail access for a couple of days.
>
No problem, hope it was great!

> The idea was to enable the console at the earliest, even before prcm_init().
> If OMAP3 doesn't need this I would suggest moving setup_clocks_for_console()
> call to s_init() in omap4/board.c
So I think it is best to move it to s_init like you said.

For now I don't plan to add this to OMAP3. If we move it to s_init the 
dev can decide to do early clock init or not.
>
> BTW, how did you fix this in your patches fianlly?

#ifndef CONFIG_OMAP34XX
         setup_clocks_for_console();
#endif

To be able to post the patch.

>
> br,
> Aneesh

Regards
Simon

      reply	other threads:[~2011-07-27 15:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-25 15:06 [U-Boot] preloader_console_init() Simon Schwarz
2011-07-27 14:39 ` V, Aneesh
2011-07-27 15:02   ` Simon Schwarz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E30289A.7010101@gmail.com \
    --to=simonschwarzcor@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.