From: Bryan Cain <bryancain3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 2/2] g3dvl: disable iDCT for now
Date: Wed, 27 Jul 2011 14:08:36 -0500 [thread overview]
Message-ID: <4E306234.5040502@gmail.com> (raw)
In-Reply-To: <1311752531.2296.0.camel@nisroch>
On 07/27/2011 02:42 AM, Ben Skeggs wrote:
> On Wed, 2011-07-20 at 13:48 -0500, Bryan Cain wrote:
>> ---
>> src/vl_hwmc.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
> The obvious question I have for this is, why?
>
> Ben
At least at the time I wrote these patches (in April), the iDCT stage
didn't work correctly with nv50. If it's fixed now, this patch can be
ignored.
Bryan
>> diff --git a/src/vl_hwmc.c b/src/vl_hwmc.c
>> index 6e9e0c7..8e24786 100644
>> --- a/src/vl_hwmc.c
>> +++ b/src/vl_hwmc.c
>> @@ -55,7 +55,7 @@ static XF86MCSurfaceInfoRec yv12_mpeg2_surface =
>> 2048,
>> 2048,
>> 2048,
>> - XVMC_IDCT | XVMC_MOCOMP | XVMC_MPEG_2,
>> + /*XVMC_IDCT |*/ XVMC_MOCOMP | XVMC_MPEG_2,
>> XVMC_SUBPICTURE_INDEPENDENT_SCALING | XVMC_BACKEND_SUBPICTURE,
>> &subpicture_list
>> };
>> @@ -69,7 +69,7 @@ static XF86MCSurfaceInfoRec uyvy_mpeg2_surface =
>> 2048,
>> 2048,
>> 2048,
>> - XVMC_IDCT | XVMC_MOCOMP | XVMC_MPEG_2,
>> + /*XVMC_IDCT |*/ XVMC_MOCOMP | XVMC_MPEG_2,
>> XVMC_SUBPICTURE_INDEPENDENT_SCALING | XVMC_BACKEND_SUBPICTURE,
>> &subpicture_list
>> };
>
>
next prev parent reply other threads:[~2011-07-27 19:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 18:48 [PATCH 2/2] g3dvl: disable iDCT for now Bryan Cain
[not found] ` <1311187717-3621-2-git-send-email-bryancain3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-07-27 7:42 ` Ben Skeggs
2011-07-27 19:08 ` Bryan Cain [this message]
[not found] ` <4E306234.5040502-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-07-27 22:54 ` Ben Skeggs
2011-07-28 18:03 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E306234.5040502@gmail.com \
--to=bryancain3-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.