All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	Amit Shah <amit.shah@redhat.com>,
	Hans de Goede <hdegoede@redhat.com>,
	qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop
Date: Wed, 27 Jul 2011 16:32:41 -0500	[thread overview]
Message-ID: <4E3083F9.20205@us.ibm.com> (raw)
In-Reply-To: <4E308155.1040300@mail.berlios.de>

On 07/27/2011 04:21 PM, Stefan Weil wrote:
> NDEBUG is normally set automatically for production code,
> and it disables assertions which is not always good.
>
> Assertions are useful even in production code unless
> you are sure that the code is bug free or the assertions
> cost to much resources - either memory or execution time.
>
> I don't think this is the case for QEMU, therefore I'd prefer
> having assertions in production code, too. This simply
> means undefining NDEBUG before including assert.h.

I don't know what constitutes "production builds" but the software that 
most people use in production (normal distributions packages) don't 
define NDEBUG.

Regards,

Anthony Liguori

>
> Regards,
> Stefan
>

  reply	other threads:[~2011-07-27 21:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-27  0:06 [Qemu-devel] [PATCH] [RFC] Add glib support to main loop Anthony Liguori
2011-07-27 20:43 ` Blue Swirl
2011-07-27 20:48   ` Anthony Liguori
2011-07-27 21:12     ` Blue Swirl
2011-07-27 21:21       ` Stefan Weil
2011-07-27 21:32         ` Anthony Liguori [this message]
2011-07-27 21:22       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E3083F9.20205@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=amit.shah@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=weil@mail.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.