All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Jouni Malinen <j@w1.fi>,
	linux-wireless@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: hostap_cs: add ID for LG cards
Date: Wed, 27 Jul 2011 18:11:29 -0400	[thread overview]
Message-ID: <4E308D11.8070405@gnu.org> (raw)
In-Reply-To: <201107272219.23501.linux@rainbow-software.org>

On 07/27/2011 04:19 PM, Ondrej Zary wrote:
> On Tuesday 26 July 2011 23:54:37 Pavel Roskin wrote:

>> I think we may want to introduce PCMCIA_DEVICE_MANF_CARD_PROD_ID3 and match
>>
>> PCMCIA_DEVICE_MANF_CARD_PROD_ID3(0x0156, 0x0002, "Version 1.02", xxx)
>>
>> Maybe some other card would be supported too?  I doubt there are any
>> Agere or Symbol cards with "Version 1.02" in the third text ID.
>
> Yes, that looks good, it would match my card too:
>    product info: "LG", "11Mbps Wireless LAN PCI Card", "Version 01.02", ""
>    manfid: 0x0156, 0x0002
>    function: 6 (network)

Good to know.

> ---------------------------
>
> Add generic "Version 01.02" match (used by many different cards) to hostap_cs.
>
> This allows LG LW1100P PCI card (with integrated CardBus bridge) to work
> (tested with rev 3.0) and probably also LW1100N (PCMCIA).
>
> Signed-off-by: Ondrej Zary<linux@rainbow-software.org>

That's not the right way to submit patches.  Anyway, I sent 3 patches to 
that effect yesterday.  One in for PCMCIA, the second is for hostap_cs 
and the third is for orinoco_cs to recognize "Version 01.01" as Agere 
firmware and to stop claiming 0x0156:0x0002 unconditionally.

I have no idea how interdependent series of patches that touch more than 
one subsystem are applied, but I guess there is a standard way.

-- 
Regards,
Pavel Roskin

  reply	other threads:[~2011-07-27 22:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26 21:14 hostap_cs: add ID for LG cards Ondrej Zary
2011-07-26 21:54 ` Pavel Roskin
2011-07-27 20:19   ` Ondrej Zary
2011-07-27 22:11     ` Pavel Roskin [this message]
2011-07-28  8:53       ` Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E308D11.8070405@gnu.org \
    --to=proski@gnu.org \
    --cc=j@w1.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.