All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V0] omap-common: move early UART clock setup to s_init
Date: Thu, 28 Jul 2011 11:44:52 +0200	[thread overview]
Message-ID: <4E312F94.50907@gmail.com> (raw)
In-Reply-To: <1311844938-17278-2-git-send-email-simonschwarzcor@gmail.com>

Hi Simon,

Am 28.07.2011 11:22, schrieb Simon Schwarz:
> Moves the early UART clock setup setup_clocks_for_console() from
> preloader_console_init() to s_init() of OMAP4.

I recommend putting this in your 'devkit8000 nand_spl support' series
before the current '2/5 omap-common: add nand_spl support' and remove
the '#ifdef CONFIG_OMAP34XX' in that patch. Albert how do you think
about this?

> Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
> ---
>  arch/arm/cpu/armv7/omap-common/spl.c |    1 -
>  arch/arm/cpu/armv7/omap4/board.c     |    1 +
>  2 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/omap-common/spl.c b/arch/arm/cpu/armv7/omap-common/spl.c
> index d177652..d380b3e 100644
> --- a/arch/arm/cpu/armv7/omap-common/spl.c
> +++ b/arch/arm/cpu/armv7/omap-common/spl.c
> @@ -259,7 +259,6 @@ void preloader_console_init(void)

I recommend adding some comment for preloader_console_init() saying
'this requires UART clocks to be enabled before' in this patch.

>  	gd->flags |= GD_FLG_RELOC;
>  	gd->baudrate = CONFIG_BAUDRATE;
>  
> -	setup_clocks_for_console();
>  	serial_init();		/* serial communications setup */
>  
>  	/* Avoid a second "U-Boot" coming from this string */

regards

Andreas Bie?mann

  reply	other threads:[~2011-07-28  9:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-28  9:22 [U-Boot] [PATCH V0] omap-common: move early UART clock setup to board.c Simon Schwarz
2011-07-28  9:22 ` [U-Boot] [PATCH V0] omap-common: move early UART clock setup to s_init Simon Schwarz
2011-07-28  9:44   ` Andreas Bießmann [this message]
2011-07-29 12:51     ` Simon Schwarz
2011-07-28 13:04   ` Wolfgang Denk
2011-07-28 14:49     ` Simon Schwarz
2011-07-28 13:02 ` [U-Boot] [PATCH V0] omap-common: move early UART clock setup to board.c Wolfgang Denk
2011-07-28 14:53   ` Simon Schwarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E312F94.50907@gmail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.