From: Pavel Roskin <proski@gnu.org>
To: "Luis R. Rodriguez" <lrodriguez@qca.qualcomm.com>
Cc: jouni@qca.qualcomm.com, hostap@lists.shmoo.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5 4/4] hostapd: add Automatic Channel Selection (ACS) support
Date: Thu, 28 Jul 2011 13:07:41 -0400 [thread overview]
Message-ID: <4E31975D.2000804@gnu.org> (raw)
In-Reply-To: <1311722362-4070-5-git-send-email-lrodriguez@qca.qualcomm.com>
On 07/26/2011 07:19 PM, Luis R. Rodriguez wrote:
> @@ -1736,7 +1736,18 @@ struct hostapd_config * hostapd_config_read(const char *fname)
> errors++;
> }
> } else if (os_strcmp(buf, "channel") == 0) {
> - conf->channel = atoi(pos);
> + if (os_strcmp(pos, "acs_survey") == 0) {
> + conf->channel = 0;
> + } else
> + conf->channel = atoi(pos);
It would be nice to enable ACS also if "channel" is not set at all. It
may look strange from the point of view of the code authors. However,
it makes sense from the point of view of the end user. If something is
not specified, the driver should be able to make a reasonable choice by
itself.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2011-07-28 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 23:19 [PATCH v5 0/4] hostapd: Add ACS support Luis R. Rodriguez
2011-07-26 23:19 ` [PATCH v5 1/4] hostapd: split up channel checking into helpers Luis R. Rodriguez
2011-07-26 23:19 ` [PATCH v5 2/4] hostapd: add offchannel support Luis R. Rodriguez
2011-07-26 23:19 ` [PATCH v5 3/4] hostapd: add survey dump support Luis R. Rodriguez
2011-07-26 23:19 ` [PATCH v5 4/4] hostapd: add Automatic Channel Selection (ACS) support Luis R. Rodriguez
2011-07-28 17:07 ` Pavel Roskin [this message]
2011-07-28 17:12 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E31975D.2000804@gnu.org \
--to=proski@gnu.org \
--cc=hostap@lists.shmoo.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.