From: Chris Simmonds <chris.simmonds@2net.co.uk>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Chris <chris@2net.co.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>,
mingo@redhat.com
Subject: Re: [RFC] [PATCH] Lightweight kernel condition variables: faster code, fewer bugs
Date: Thu, 28 Jul 2011 20:44:45 +0100 [thread overview]
Message-ID: <4E31BC2D.50306@2net.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1107281256240.1990-100000@iolanthe.rowland.org>
On 28/07/11 18:00, Alan Stern wrote:
> On Wed, 27 Jul 2011, Chris Simmonds wrote:
>
>> Hi,
>>
>> This patch adds lightweight condition variables to the kernel to reduce
>> complexity and improve the efficiency of some synchronisation tasks.
>> They are very similar to POSIX condition variables.
>
> It seems like a reasonable sort of thing to do, as far as I can see.
>
Thanks, and thank you for the review.
> One little problem here. These routines may well be large enough
> that it's inefficient to inline them. In that case they should be
> declared in wait.h but defined somewhere else, such as kernel/wait.c.
> Conversely, if you do think they deserve to be inlined then they should
> be marked as such.
I was not planning to make them inline. I will change the patch to do as
you say.
>
> P.S.: Does this come through checkpatch.pl unscathed?
>
In truth, no. The next one will.
Chris.
prev parent reply other threads:[~2011-07-28 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 10:12 [RFC] [PATCH] Lightweight kernel condition variables: faster code, fewer bugs Chris Simmonds
2011-07-28 17:00 ` Alan Stern
2011-07-28 19:44 ` Chris Simmonds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E31BC2D.50306@2net.co.uk \
--to=chris.simmonds@2net.co.uk \
--cc=chris@2net.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.