From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59804)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1QmfzU-0002yu-QW
	for qemu-devel@nongnu.org; Fri, 29 Jul 2011 01:52:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1QmfzT-0003J8-LO
	for qemu-devel@nongnu.org; Fri, 29 Jul 2011 01:52:08 -0400
Received: from isrv.corpit.ru ([86.62.121.231]:32795)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1QmfzT-0003Ic-FQ
	for qemu-devel@nongnu.org; Fri, 29 Jul 2011 01:52:07 -0400
Message-ID: <4E324A7C.3020207@msgid.tls.msk.ru>
Date: Fri, 29 Jul 2011 09:51:56 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <20110606083447.47A88527A@gandalf.tls.msk.ru>
	<4DF29AD2.2@msgid.tls.msk.ru>
	<BANLkTikhWgNnKDs9i6htMHT1xV5EvvWafw@mail.gmail.com>
	<4E205A57.2040309@virtualcomputer.com>
	<CAAu8pHteXwLpDBEXTLpMFna3uK4j=bFhbcbJ+MtY9tdzqMLyYA@mail.gmail.com>
	<20110729014943.GK14976@valinux.co.jp>
In-Reply-To: <20110729014943.GK14976@valinux.co.jp>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] v6 revamp acpitable parsing and allow to
 specify complete (headerful) table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: Blue Swirl <blauwirbel@gmail.com>, John Baboval <john.baboval@virtualcomputer.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@linux.vnet.ibm.com>

29.07.2011 05:49, Isaku Yamahata wrote:
> On Fri, Jul 15, 2011 at 07:51:43PM +0300, Blue Swirl wrote:
>> On Fri, Jul 15, 2011 at 6:18 PM, John Baboval
>> <john.baboval@virtualcomputer.com> wrote:
>>> Is there something I can do to help take this patch the rest of the way?
>>>
>>> I'd hate to see it die because of a style issue and a compiler warning.
>>
>> There's also suspicious missing 'break' statement. How about fixing
>> the issues and submitting the patch?
> 
> I fixed the compile error.

Oh, another one? :)

> I think the missing break is intentional, so added an comment there. Michael?

Yes it's intentional, you're right.

> Blue, can you please take a look of it?

I think it's hopeless.

/mjt