From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@st.com (viresh kumar) Date: Fri, 29 Jul 2011 16:53:52 +0530 Subject: [PATCH 00/18] dmaengine/amba-pl08x updates In-Reply-To: <20110729111920.GK25640@n2100.arm.linux.org.uk> References: <20110729105759.GE25640@n2100.arm.linux.org.uk> <4E329616.2030505@st.com> <20110729111920.GK25640@n2100.arm.linux.org.uk> Message-ID: <4E329848.7070606@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/29/2011 04:49 PM, Russell King - ARM Linux wrote: > Ok, so lets have the driver explicitly enforce one SG entry if peripheral > flow is set. It would also be a good idea to pass not zero length, but > the real transfer size in the SG entry for the sake of having the API > know the full information about the transfer. In my case, JPEG driver doesn't know how much data to transfer. So i have to send zero from there. Also, i am not sure why would peripheral needs to be flow controller if the peripherals driver already know how much to transfer? > > (Ok, it already only supports one SG entry, but that's something else > which needs fixing - which may be possible now that you've cleaned up > the LLI creation code.) > . Yes. I cleaned it up. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932179Ab1G2LYh (ORCPT ); Fri, 29 Jul 2011 07:24:37 -0400 Received: from eu1sys200aog107.obsmtp.com ([207.126.144.123]:48347 "EHLO eu1sys200aog107.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932077Ab1G2LYg (ORCPT ); Fri, 29 Jul 2011 07:24:36 -0400 X-Greylist: delayed 2061 seconds by postgrey-1.27 at vger.kernel.org; Fri, 29 Jul 2011 07:24:35 EDT Message-ID: <4E329848.7070606@st.com> Date: Fri, 29 Jul 2011 16:53:52 +0530 From: viresh kumar User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Russell King - ARM Linux Cc: "linus.walleij@linaro.org" , Pratyush ANAND , Rajeev KUMAR , Bhupesh SHARMA , Shiraz HASHIM , "vinod.koul@intel.com" , "linux-kernel@vger.kernel.org" , Vipin KUMAR , Armando VISCONTI , Amit VIRDI , Vipul Kumar SAMAR , "viresh.linux@gmail.com" , Deepak SIKRI , "dan.j.williams@intel.com" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 00/18] dmaengine/amba-pl08x updates References: <20110729105759.GE25640@n2100.arm.linux.org.uk> <4E329616.2030505@st.com> <20110729111920.GK25640@n2100.arm.linux.org.uk> In-Reply-To: <20110729111920.GK25640@n2100.arm.linux.org.uk> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/29/2011 04:49 PM, Russell King - ARM Linux wrote: > Ok, so lets have the driver explicitly enforce one SG entry if peripheral > flow is set. It would also be a good idea to pass not zero length, but > the real transfer size in the SG entry for the sake of having the API > know the full information about the transfer. In my case, JPEG driver doesn't know how much data to transfer. So i have to send zero from there. Also, i am not sure why would peripheral needs to be flow controller if the peripherals driver already know how much to transfer? > > (Ok, it already only supports one SG entry, but that's something else > which needs fixing - which may be possible now that you've cleaned up > the LLI creation code.) > . Yes. I cleaned it up. -- viresh