From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@st.com (viresh kumar) Date: Fri, 29 Jul 2011 17:00:07 +0530 Subject: [PATCH 12/18] dmaengine/amba-pl08x: Add prep_single_byte_llis() routine In-Reply-To: <20110729110638.GH25640@n2100.arm.linux.org.uk> References: <20110729110638.GH25640@n2100.arm.linux.org.uk> Message-ID: <4E3299BF.6030707@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/29/2011 04:36 PM, Russell King - ARM Linux wrote: >> > +static inline void prep_byte_width_lli(struct pl08x_lli_build_data *bd, >> > + u32 *cctl, u32 len, int num_llis, size_t *total_bytes) >> > +{ >> > + *cctl = pl08x_cctl_bits(*cctl, 1, 1, len); >> > + pl08x_fill_lli_for_desc(bd, num_llis, len, *cctl); >> > + (*total_bytes) += len; > Seeing as your patch series started with a cleanup of spacing/tabbing, > it's surprising to find a patch introducing new code which has broken > tabbing. > Haah.... How can i do this? Sorry will fix this. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932217Ab1G2Lat (ORCPT ); Fri, 29 Jul 2011 07:30:49 -0400 Received: from eu1sys200aog110.obsmtp.com ([207.126.144.129]:46052 "EHLO eu1sys200aog110.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932106Ab1G2Las (ORCPT ); Fri, 29 Jul 2011 07:30:48 -0400 Message-ID: <4E3299BF.6030707@st.com> Date: Fri, 29 Jul 2011 17:00:07 +0530 From: viresh kumar User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Russell King - ARM Linux Cc: "linus.walleij@linaro.org" , "vinod.koul@intel.com" , "dan.j.williams@intel.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Armando VISCONTI , Shiraz HASHIM , Vipin KUMAR , Rajeev KUMAR , Deepak SIKRI , Vipul Kumar SAMAR , Amit VIRDI , Pratyush ANAND , Bhupesh SHARMA , "viresh.linux@gmail.com" Subject: Re: [PATCH 12/18] dmaengine/amba-pl08x: Add prep_single_byte_llis() routine References: <20110729110638.GH25640@n2100.arm.linux.org.uk> In-Reply-To: <20110729110638.GH25640@n2100.arm.linux.org.uk> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/29/2011 04:36 PM, Russell King - ARM Linux wrote: >> > +static inline void prep_byte_width_lli(struct pl08x_lli_build_data *bd, >> > + u32 *cctl, u32 len, int num_llis, size_t *total_bytes) >> > +{ >> > + *cctl = pl08x_cctl_bits(*cctl, 1, 1, len); >> > + pl08x_fill_lli_for_desc(bd, num_llis, len, *cctl); >> > + (*total_bytes) += len; > Seeing as your patch series started with a cleanup of spacing/tabbing, > it's surprising to find a patch introducing new code which has broken > tabbing. > Haah.... How can i do this? Sorry will fix this. -- viresh